REST API: Posts/Pages endpoint prefixes private pages titles.

[youknowriad]

Discovered in ​https://github.com/WordPress/gutenberg/issues/56154

When using the /posts or /pages, REST API, for private posts or pages, you get the following title property:

title: { raw: "Some title", rendered: "Private: Some title" }

I would like to understand more why did we decide to prefix the rendered titles here knowing that we already have the information about the status separately.

Maybe I'm misunderstanding what "rendered" property is about, but IMO we should consider removing these prefixes as REST API clients should have access to the rendered title without it (like the linked example above: render the title in the list views)

[swissspidy]

I don't think there was a conscious decision to explicitly add this to the REST API. It simply uses get_the_title() internally which happens to add the "Private:" prefix (but only if you are not in the admin!).

By default, get_the_title() adds a "Protected:" prefix too, but the REST API removes it (see \WP_REST_Posts_Controller::protected_title_format()). This was added in ​https://github.com/WP-API/WP-API/pull/2720 because you can still access a protected post in the API, but you can't see the content & excerpt fields.

For consistency reasons it sounds reasonable to me to omit the prefix for "Private" as well. Would probably be good to mention it in a misc dev note if it lands.

---

Aside: Private: for empty private pages is just wrong IMO.

When using the /posts or /pages, REST API, for private posts or pages, you get the following title property:

title: { raw: "Some title", rendered: "Private: Some title" }

As discussed on the trac ticket, this PR removes the prefix from private posts (just like what we do for protected posts)

[youknowriad]

In 58783:

REST API: Remove post status prefix from REST API responses.

When using the /posts or /pages endpoints, for private posts or pages, you get the following title property: { raw: "Some title", rendered: "Private: Some title" }
this commit removes the prefix from rendered private posts titles (just like what we do for protected posts)

Props youknowriad, swissspidy, timothyblynjacobs, sergeybiryukov, ramonopoly.
Fixes #61639.

commit https://core.trac.wordpress.org/changeset/58783