THEME: Simple light – 1.3

[alexanderkoledov]

Simple light - 1.2

Light theme for you WprdPress site

Theme URL -
Author URL - ​https://profiles.wordpress.org/alexanderkoledov/

Trac Browser - https://themes.trac.wordpress.org/browser/simple-light/1.2
WordPress.org - ​https://wordpress.org/themes/simple-light/

SVN - ​https://themes.svn.wordpress.org/simple-light/1.2
ZIP - ​https://wordpress.org/themes/download/simple-light.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=simple-light/1.1&new_path=simple-light/1.2

History:

Ticket	Summary	Status	Resolution	Owner
#82334	THEME: Simple light – 1.1	closed	not-approved	acosmin
#85381	THEME: Simple light – 1.3	closed	live	acosmin
(this ticket)
#86888	THEME: Simple light – 1.4	closed	live	themetracbot
#134581	THEME: Simple light – 1.5	closed	live	themetracbot

Theme Check Results:

• RECOMMENDED: Theme URI: is missing from your style.css header.

[alexanderkoledov]

Hi! Thanks for the detailed feedback)

[acosmin]

Hi! @alexanderkoledov

I'll be reviewing your theme, please fix the following issues:

---

Notice:

• I normally do follow-ups/recheck the tickets/replies on Wednesday and Friday. If you manage to fix these issues by that time, the theme will most likely go live. So please read my review carefully.
• Please keep the discussion in ticket, contacting me on Slack or through other methods doesn't guarantee a quicker response time.
• If there is no activity in this ticket (within 7 days), the ticket will be closed.

---

1. All the notifications generated by a theme should use the admin_notices API and follow the core design pattern. They must be dismissible. Everything wrapped in the admin notice needs to follow core UI design for the notices

2. functions.php
   • L515, Email: should be translatable.
   • remove commented out code

3. Provide a ​unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, wp_enqueue_script/style handle names, add_image_size names, wp_script_add_data keys etc. Theme nav menu locations and sidebar IDs are exceptions.
   • You have multiple prefixes, light_theme_ & lighttheme_. Use only one, it should be simple_light_

4. breadcrumbs.php
   • L9, I would use home_url instead.

5. class-light_theme-widget-smm.php
   • L81, you can't use wp_filter_nohtml_kses on all of them. You have a link, a class name and a hex color.
     • esc_url_raw, sanitize_html_class, sanitize_hex_color

6. editor-styles.css
   • use the wp_enqueue_scripts api for those google fonts

7. style.css
   • L11, there is not LICENSE.txt file.

8. searchform.php
   • L3, that's an attribute + get_search_query() doesn't need to be escaped.

9. header.php
   • L82, that's an attribute

10. readme.txt
    • remove L7,64

11. please read the ​placeholder images requirement

---

1. Skip link - ok

2. ​Keyboard navigation - not ok
   • Some resources to help you:
     • ​Information on the requirement
     • Video help for: ​Modals, ​Links, ​Forms, ​Menus
     • Check TwentyTwenty using tab and shift+tab as an example
   • Issues with your theme:
     • The wp admin bar styles should not be affected by your styles, focus for example
     • the wp admin bar and header overlap in sticky mode.
     • Some of the form elements have no style on focus, comments form for example

[alexanderkoledov]

Hi!@acosmin
Wow! Thanks for the strong support!

[themetracbot]

Simple light - 1.3

Light theme for you WordPress site

Theme URL -
Author URL - ​https://profiles.wordpress.org/alexanderkoledov/

Trac Browser - https://themes.trac.wordpress.org/browser/simple-light/1.3
WordPress.org - ​https://wordpress.org/themes/simple-light/

SVN - ​https://themes.svn.wordpress.org/simple-light/1.3
ZIP - ​https://wordpress.org/themes/download/simple-light.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=simple-light/1.2&new_path=simple-light/1.3

History:

Ticket	Summary	Status	Resolution	Owner
#82334	THEME: Simple light – 1.1	closed	not-approved	acosmin
#85381	THEME: Simple light – 1.3	closed	live	acosmin
(this ticket)
#86888	THEME: Simple light – 1.4	closed	live	themetracbot
#134581	THEME: Simple light – 1.5	closed	live	themetracbot

Theme Check Results:

• RECOMMENDED: Theme URI: is missing from your style.css header.

[acosmin]

Looks ok, congrats! @alexanderkoledov

[alexanderkoledov]

Replying to acosmin:

Looks ok, congrats! @alexanderkoledov

Thanks)