THEME: Simple light – 1.1

[alexanderkoledov]

Simple light - 1.1

Light theme for you WprdPress site

Theme URL -
Author URL - ​https://profiles.wordpress.org/alexanderkoledov/

Trac Browser - https://themes.trac.wordpress.org/browser/simple-light/1.1
WordPress.org - ​https://wordpress.org/themes/simple-light/

SVN - ​https://themes.svn.wordpress.org/simple-light/1.1
ZIP - ​https://wordpress.org/themes/download/simple-light.1.1.zip?nostats=1

History:

Ticket	Summary	Status	Resolution	Owner
#82334	THEME: Simple light – 1.1	closed	not-approved	acosmin
(this ticket)
#85381	THEME: Simple light – 1.3	closed	live	acosmin
#86888	THEME: Simple light – 1.4	closed	live	themetracbot
#134581	THEME: Simple light – 1.5	closed	live	themetracbot

Theme Check Results:

• RECOMMENDED: Theme URI: is missing from your style.css header.

[acosmin]

Hi @alexanderkoledov

This ticket is marked as not-approved for one or more reasons:

• You didn't read ​the requirements or you didn't manage to apply them in the right way.
• The theme has too many issues => a lot of time to review.
• If I think it would take me more than 10 minutes to do a follow-up on your updates (related to the 2nd point).
• PHP or JS Errors that make the theme unusable.

---

You have a full review in the following lines, fix your theme and next time it will probably go live. If you have questions, please post them in this ticket (please don't contact me on Slack or via social media/contact form).

Use this upload form to submit your update: ​https://wordpress.org/themes/upload/

---

1. All ​Theme Sniffer reported Errors need to be fixed.

2. No PHP & JS issues, found:

   Notice: Undefined index: icon in \wp-content\themes\simple-light\classes\class-light_theme-widget-smm.php on line 43
   Notice: Undefined index: color in \wp-content\themes\simple-light\classes\class-light_theme-widget-smm.php on line 44
   

3. Customizer
   • Adding a custom logo and removing it will make the text logo (and description) disappear aswell

4. Read the ​screenshot requirements

5. Provide a ​unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, wp_enqueue_script/style handle names, add_image_size names, wp_script_add_data keys etc. Theme nav menu locations and sidebar IDs are exceptions.
   • examples:
     • functions.php:L217,218,226,242

6. Not allowed:
   • functions.php:L337
   • style.css:L15,16 use wp_enqueue_style instead

7. Validate and/or sanitize untrusted data before entering into the database. All untrusted data should be escaped before output. (See: ​Data Validation)
   • functions.php
     • L382, title is an attribute
   • breadcrumbs.php:L9,33...
   • class-light_theme-widget-smm.php you're not sanitizing any of the inputs in update
   • searchform.php:L1,3
   • index.php:L3, recheck the file, you're using the wrong escaping functions
     • front-page.php same
   • comments.php placeholders
   • template-parts/*.php

8. ​Use the Customizer for implementing theme options
   • slider.php
     • also, that's content creation.

9. All theme text strings are to be translatable
   • class-light_theme-widget-smm.php:L19,25
   • header.php:L110
   • 404.php

10. No minification of scripts or files unless you provide original files
    • check assets/vendor

11. All your .po files have Automattic in copyright

12. header.php
    • L7, make sure that the pingback_url is conditional, since pings can be turned off.
      • is_singular() && pings_open( get_queried_object() ) and escape it.
    • L8,17-29 use wp_enqueue_scripts

13. Read ​Presentation vs Functionality

14. readme.txt
    • Missing license information for some of the vendor files
    • That version of FancyBox is not GPL compatible
    • Pixabay images are not allowed on wp.org
    • ​Tags are wrong in readme.txt

---

1. Skip link - ok

2. Keyboard navigation
   • Submenus can't be toggled using the keyboard.