Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes(31721): Added the fragment instead of the whole URL #31767

Merged
merged 8 commits into from
Feb 22, 2024

Conversation

code-Gambler
Copy link
Contributor

Why:

This PR solves the same issue as this pr, it is just I had included this whole URL instead of just the fragment, this PR corrects that, as correctly pointed out by Samuel.

Thank you @samuelcolvin
Closes:
31721

What's being changed (if available, include any code snippets, screenshots, or gifs):

Only a link to this page is being added

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@code-Gambler code-Gambler requested a review from a team as a code owner February 22, 2024 01:41
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 22, 2024
Copy link
Contributor

github-actions bot commented Feb 22, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
site-policy/privacy-policies/github-general-privacy-statement.md fpt
fpt

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team site policy Content related to site policy and removed triage Do not begin working on this issue until triaged by the team labels Feb 22, 2024
@nguyenalex836
Copy link
Contributor

@code-Gambler Hey 👋 good to see you again! Let me check with our site policy team regarding adding the fragment vs. the complete URL - will be back once I have an update 💛

@nguyenalex836
Copy link
Contributor

@code-Gambler This looks great! I'll update the branch and get this merged once tests are passing 🍏

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Feb 22, 2024
Merged via the queue into github:main with commit b2ab3f5 Feb 22, 2024
40 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team site policy Content related to site policy
3 participants