-
Notifications
You must be signed in to change notification settings - Fork 58.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes(31721): Added the fragment instead of the whole URL #31767
Conversation
Added the fragment
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@code-Gambler Hey 👋 good to see you again! Let me check with our site policy team regarding adding the fragment vs. the complete URL - will be back once I have an update 💛 |
@code-Gambler This looks great! I'll update the branch and get this merged once tests are passing 🍏 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
This PR solves the same issue as this pr, it is just I had included this whole URL instead of just the fragment, this PR corrects that, as correctly pointed out by Samuel.
Thank you @samuelcolvin
Closes:
31721
What's being changed (if available, include any code snippets, screenshots, or gifs):
Only a link to this page is being added
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.