Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes Issue(31721): Added the link to What are your cookie choices and controls? #31733

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Closes Issue(31721): Added the link to What are your cookie choices and controls? #31733

merged 3 commits into from
Feb 21, 2024

Conversation

code-Gambler
Copy link
Contributor

Why:

The link to What are your cookie choices and controls? was missing, so added the link in the content/site-policy/privacy-policies/github-general-privacy-statement.md file
Closes:
31721

What's being changed (if available, include any code snippets, screenshots, or gifs):

Only a link to this page is being added

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.
@code-Gambler code-Gambler requested a review from a team as a code owner February 20, 2024 18:11
@welcome Welcome
Copy link

welcome bot commented Feb 20, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 20, 2024 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
site-policy/privacy-policies/github-general-privacy-statement.md fpt
 fpt

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
@code-Gambler code-Gambler changed the title CLose Issue(31721): Added the link to What are your cookie choices and controls? Feb 20, 2024
@nguyenalex836 nguyenalex836 linked an issue Feb 20, 2024 that may be closed by this pull request
Typo in privacy policy #31721
Closed
1 task
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team site policy Content related to site policy and removed triage Do not begin working on this issue until triaged by the team labels Feb 20, 2024
@nguyenalex836
Copy link
Contributor

@code-Gambler Thanks so much for opening a PR! Looks great to me - I'm going to ask our Site Policy team to review ✨

Internal: asked here
@nguyenalex836
Copy link
Contributor

@code-Gambler Thanks again for opening this PR! I'll update the branch and get this merged once tests are passing 🍏
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Feb 21, 2024
Merged via the queue into github:main with commit 95373c6 Feb 21, 2024
39 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡
@samuelcolvin
Copy link

Why have you included the full URL, not just the fragment?
@code-Gambler
Copy link
Contributor Author

code-Gambler commented Feb 22, 2024 •
edited
Loading

Why have you included the full URL, not just the fragment?

I looked at other links, they had the whole URL, so I included the whole URL
Now when I checked back, I realized they were all leading to github.com due to which they had the full URL.
I should have included the fragment!

What do you guys suggest? Should I make a new PR with just the fragment?
@samuelcolvin
Copy link

Should definitely just be the fragment as it's in the same file.
@code-Gambler code-Gambler mentioned this pull request Feb 22, 2024
Merged
2 tasks
@code-Gambler
Copy link
Contributor Author

samuelcolvin

Submitted a new pr with only the fragment!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team site policy Content related to site policy
4 participants
@code-Gambler @nguyenalex836 @samuelcolvin @khxu