[Follow up to #36587] Brave is still crashing when opening and quickly closing multiple NTPs

[hffvld]

Description:

Follow-up to #36587

debug	12:45:33.964658-0700	Client	[ads] Tab id 93003170 was closed
debug	12:45:33.964742-0700	Client	[ads] Triggered event: 08 (0:0:900 s)
debug	12:45:34.016357-0700	Client	[ads] Created tab with id 93003170
debug	12:45:34.016403-0700	Client	[ads] Triggered event: 0D (0:0:900 s)
debug	12:45:34.016438-0700	Client	[ads] Tab id 93003170 did become occluded
debug	12:45:34.016469-0700	Client	[ads] Triggered event: 09 (0:0:900 s)
debug	12:45:34.017515-0700	Client	[ads] Tab id -1860586983 did become focused
debug	12:45:34.017641-0700	Client	[ads] Triggered event: 09 (0:0:900 s)
info	12:45:34.047111-0700	Client	[ads] Failed to get creative new tab page ad
debug	12:45:34.047142-0700	Client	[ads] Failed to fire new tab page ad event due to missing creative instance id 0d3692e8-ab36-4afe-b543-ce401634bee5
debug	12:45:34.047173-0700	Client	[ads] Failed to fire new tab page ad kServed event for placement id 56D6F447-B4B8-41C7-8CB4-3AD1DC2E03B6 and creative instance id 0d3692e8-ab36-4afe-b543-ce401634bee5

Steps to Reproduce

1. Launch Brave on iPhone or iPad
2. Settings > Tabs Bar > Enable it
3. Go back and open any website
4. Open multiple NTPs (~5 - 10) and quickly close them > Observe Brave is crashing

Actual result:

Brave crashes when opening and quickly closing multiple NTPs. It looks like a Regression, which starts in 1.62, I wasn't able to reproduce it with 1.61.1

iPhone

2024-03-29_12-29-03.mp4

iPad

2024-03-29_12-35-20.mp4

Expected result:

Brave must not crash when opening and closing multiple NTPs

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.65 (96)
BraveCore: 1.65.96 (123.0.6312.86)

• Can you reproduce this issue with the most recent build from TestFlight? YES
• Can you reproduce this issue with the previous version of the current build from TestFlight? YES
• Can you reproduce this issue with the current build from AppStore? YES

Device details:

- iPhone 14 / iOS 17.4.1
- iPad Air / iPadOS 16.7.2

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

cc @kylehickinson

[kjozwiak]

The above requires 1.65.105 or higher for 1.65.x verification 👍

[hffvld]

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 / iOS 17.5
- iPad Air / iPadOS 16.7.2
Brave build: 1.65 (112)
BraveCore: 1.65.112 (124.0.6367.29)

---

STEPS:

1. Follow the steps from [Follow up to #36587] Brave is still crashing when opening and quickly closing multiple NTPs #37224 (comment)
2. Verify

ACTUAL RESULTS:

• Verified Brave is not crashing

---

iPhone

2024-04-15_09-54-55.mp4

iPad

2024-04-15_09-58-35.mp4