Crash when quickly closing an NTP-SI tab right after its created

[kylehickinson]

Description:

Steps to Reproduce

1. Visit any page on iPad with Top-URL bar and Tabs showing.
2. Click the URL bar.
3. Tap on the PLUS sign to open a new tab.
4. Do it again.
5. Close all the newly opened tabs until you get back to the original page.

Actual result:

Crashes

Expected result:

No crash

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily

Brave Version:

Most likely as far back as 1.57 (when NTP-SI P3A was added)

[hffvld]

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 / iOS 17.4.1
- iPad Air / iPadOS 16.7.2
Brave build: 1.65 (96)
BraveCore: 1.65.96 (123.0.6312.86)

Filed follow-up issue #37224

STEPS:

1. Follow the steps from Crash when quickly closing an NTP-SI tab right after its created  #36587 (comment)
2. Verify on iPad and iPhone

ACTUAL RESULTS:

• Verify that Brave is not crashing. Observe that Brave is still crashing.
• Verified the same on both iPad and iPhone.

---

iPhone

2024-03-29_12-29-03.mp4

iPad

2024-03-29_12-35-20.mp4