Build: Polyfill __dirname in php-wam/node ESM via banner option #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Related to #1587
The recent changes to publish
@php-wasm/nodeas ESM broke the.wasmfiles paths in the published package. Specifically,__dirname + '/php_8_0.wasm'became/home/runner/work/wordpress-playground/wordpress-playground/node_modules/@php-wasm/node/php_8_0.wasmwhich is undesirable.This PR polyfills the
__dirnamevariable with ESM-compliant alternatives in the ESM version of the@php-wasm/nodepackage.Testing instructions
npm run build@php-wasm/nodepackage has the correct.wasmfiles paths.