php-wasm/node: Ship as ESM and CJS #1585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@php-wasm/node
package used to be CommonJS only. This created tricky dependency identity problems in ESM applications, e.g. in #1577 the main script imports the ESM version of@php-wasm/universal
, but@php-wasm/node
imports the CJS version of it.This PR ensures
@php-wasm/node
has an ESM version available.This is first step towards solving #1583
Closes #1579 Closes #1577
Testing instructions
Run
npm run build
, copy the built packages fromdist/packages/php-wasm
to node_modules in another directory, create a test.js script with the following contents:Then create a package.json file with
{"type":"module"}
and confirm that running test.js works. Then create test.cjs file as follows:And confirm this one works, too.