-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get etag method #6820
base: trunk
Are you sure you want to change the base?
Get etag method #6820
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Hi @vraja-pro! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes look good to me. I am happy to approve when my other comment is addressed.
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
@vraja-pro The trac ticket you've linked this pull request to is closed on a previous milestone. If you'd like to suggest some follow up changes, are you able to open a new ticket on the Script Loader component. Please include a brief explanation on the ticket as to why you'd like to make the follow up changes. Thanks |
Co-authored-by: Martin Krcho <1962663+martinkrcho@users.noreply.github.com>
Co-authored-by: Martin Krcho <1962663+martinkrcho@users.noreply.github.com>
Co-authored-by: Martin Krcho <1962663+martinkrcho@users.noreply.github.com>
Hey @peterwilsoncc I created a new trac ticket and updated the PR description with it's new number. |
Co-authored-by: Martin Krcho <1962663+martinkrcho@users.noreply.github.com>
Co-authored-by: Martin Krcho <1962663+martinkrcho@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
@mukeshpanchal27 would you please re-review this task? |
tests/phpunit/tests/dependencies.php
Outdated
wp_enqueue_script( $handle, 'https://example.cdn', array(), $ver ); | ||
} | ||
|
||
$this->assertSame( $instance->get_etag( $wp_version, array_keys( $load ) ), $expected, 'md hash for ' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The $expected
should be the first argument, and the message parameter should be improved to provide more context on what is failing, as it currently displays the same message for all data.
Example:
$this->assertSame( $expected, $actual, 'Expected value does not match actual value for [specific context]' );
This way, when a test fails, the message will give more information about the specific context of the failure, making it easier to diagnose and fix issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the comments for the hash source string to the data provider and added it to the message.
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. Minor suggestion other then looks good to me.
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Added tests to change make in PR for 61485
Moved the logic to a separate method under wp-dependencies class and added unit tests.
Trac ticket: https://core.trac.wordpress.org/ticket/61485
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.