Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get etag method #6820

Open
wants to merge 24 commits into
base: trunk
Choose a base branch
from
Open

Get etag method #6820

wants to merge 24 commits into from

Conversation

vraja-pro
Copy link

@vraja-pro vraja-pro commented Jun 13, 2024

Added tests to change make in PR for 61485

Moved the logic to a separate method under wp-dependencies class and added unit tests.

Trac ticket: https://core.trac.wordpress.org/ticket/61485


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Jun 13, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props vrajadas, martinkrcho, mukesh27, peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Hi @vraja-pro! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link

@martinkrcho martinkrcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes look good to me. I am happy to approve when my other comment is addressed.

vraja-pro and others added 2 commits June 20, 2024 22:39
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
@peterwilsoncc
Copy link
Contributor

@vraja-pro The trac ticket you've linked this pull request to is closed on a previous milestone. If you'd like to suggest some follow up changes, are you able to open a new ticket on the Script Loader component.

Please include a brief explanation on the ticket as to why you'd like to make the follow up changes.

Thanks

vraja-pro and others added 4 commits June 22, 2024 10:31
Co-authored-by: Martin Krcho <1962663+martinkrcho@users.noreply.github.com>
Co-authored-by: Martin Krcho <1962663+martinkrcho@users.noreply.github.com>
Co-authored-by: Martin Krcho <1962663+martinkrcho@users.noreply.github.com>
@vraja-pro
Copy link
Author

Hey @peterwilsoncc I created a new trac ticket and updated the PR description with it's new number.

vraja-pro and others added 2 commits June 24, 2024 11:18
Co-authored-by: Martin Krcho <1962663+martinkrcho@users.noreply.github.com>
Co-authored-by: Martin Krcho <1962663+martinkrcho@users.noreply.github.com>
vraja-pro and others added 6 commits June 24, 2024 15:00
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
@martinkrcho
Copy link

@mukeshpanchal27 would you please re-review this task?

src/wp-includes/class-wp-dependencies.php Outdated Show resolved Hide resolved
src/wp-includes/class-wp-dependencies.php Outdated Show resolved Hide resolved
tests/phpunit/tests/dependencies.php Outdated Show resolved Hide resolved
wp_enqueue_script( $handle, 'https://example.cdn', array(), $ver );
}

$this->assertSame( $instance->get_etag( $wp_version, array_keys( $load ) ), $expected, 'md hash for ' );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The $expected should be the first argument, and the message parameter should be improved to provide more context on what is failing, as it currently displays the same message for all data.

Example:

$this->assertSame( $expected, $actual, 'Expected value does not match actual value for [specific context]' );

This way, when a test fails, the message will give more information about the specific context of the failure, making it easier to diagnose and fix issues.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the comments for the hash source string to the data provider and added it to the message.

vraja-pro and others added 5 commits July 3, 2024 09:14
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Minor suggestion other then looks good to me.

src/wp-includes/class-wp-dependencies.php Outdated Show resolved Hide resolved
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants