Get WordPress

Make WordPress Core

Opened 6 weeks ago

Last modified 3 weeks ago

#61485 new enhancement

Refactor Etag-based cache busting for styles and scripts solution and add tests

Reported by: vrajadas's profile vrajadas Owned by:
Milestone: 6.7 Priority: normal
Severity: normal Version:
Component: Script Loader Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

Following issue #58433, I wanted to add tests to the solution and then realised they is code duplication. I move the logic to method in the class both wp_script and wp_style extend.

I also added tests.
Test instructions are the same as in #58433, since this issue doesn't change functionality.
Github PR is ​https://github.com/WordPress/wordpress-develop/pull/6820

Change History (4)

This ticket was mentioned in ​PR #6820 on ​WordPress/wordpress-develop by ​@vrajadas.
6 weeks ago #1

  • Keywords has-patch has-unit-tests added

Added tests to change make in PR for ​58433

Moved the logic to a separate method under wp-dependencies class and added unit tests.

Trac ticket: https://core.trac.wordpress.org/ticket/61485

​@vrajadas commented on ​PR #6820:
6 weeks ago #2

Hey @peterwilsoncc I created a new trac ticket and updated the PR description with it's new number.

​@martin.krcho commented on ​PR #6820:
5 weeks ago #3

@mukeshpanchal27 would you please re-review this task?

#4 @mukesh27
3 weeks ago

  • Milestone changed from Awaiting Review to 6.7
  • Version 6.6 deleted

The PR looks good to me and approved, happy to get more folks eye.

Move to 6.7 milestone.

Note: See TracTickets for help on using tickets.