Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional display of edit links #521

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Conditional display of edit links #521

merged 6 commits into from
Jul 15, 2024

Conversation

ernilambar
Copy link
Member

Fixes #515

  • Display edit link only if file is editable
@ernilambar ernilambar marked this pull request as ready for review July 12, 2024 10:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 12, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
@swissspidy swissspidy added this to the 1.1.0 milestone Jul 13, 2024
@swissspidy swissspidy added WP Admin Issues for the WP Admin screen [Type] Enhancement A suggestion for improvement of an existing feature labels Jul 13, 2024
mukeshpanchal27
mukeshpanchal27 requested changes Jul 15, 2024
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ernilambar for the PR. Left one feedback other then it looks good to me.
includes/Plugin_Context.php Show resolved Hide resolved
@mukeshpanchal27
Copy link
Member

Thanks for the update.

It still adds links to the .husky/_/husky.sh file. When we click on the link, it shows "Sorry, that file cannot be edited."

@swissspidy, do we need to exclude the .husky folder? Is it worth checking the files from that folder? We already exclude some folders in PR #237.
@ernilambar
Copy link
Member Author

We are currently excluding filename starting with .. May be we should also exclude folders starting with . like core does.
@mukeshpanchal27
Copy link
Member

We are currently excluding filename starting with .. May be we should also exclude folders starting with . like core does.

+1 That also works.
@mukeshpanchal27 mukeshpanchal27 merged commit 484855c into WordPress:trunk Jul 15, 2024
22 checks passed
@ernilambar ernilambar deleted the 515-view-in-code-editor branch July 15, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement of an existing feature WP Admin Issues for the WP Admin screen
3 participants
@ernilambar @mukeshpanchal27 @swissspidy