Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide "View in code editor" link for uneditable files #515

Closed
ernilambar opened this issue Jul 9, 2024 · 1 comment · Fixed by #521
Closed

Hide "View in code editor" link for uneditable files #515

ernilambar opened this issue Jul 9, 2024 · 1 comment · Fixed by #521
Labels
[Type] Enhancement A suggestion for improvement of an existing feature WP Admin Issues for the WP Admin screen

Comments

@ernilambar
Copy link
Member

ernilambar commented Jul 9, 2024 •
edited
Loading

Errors like hidden_files, application_detected, no_plugin_readme, etc should not have View in code editor link as those files are not editable. Clicking on those links are now just going to error page.

Example:

Screenshot 2024-07-09 at 11 01 46 AM
@ernilambar ernilambar added the WP Admin Issues for the WP Admin screen label Jul 9, 2024
@swissspidy swissspidy added the [Type] Enhancement A suggestion for improvement of an existing feature label Jul 11, 2024
@swissspidy
Copy link
Member

Is there a function in WP to determine whether a file can be edited or not? Then we can just reuse that.
@ernilambar ernilambar mentioned this issue Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement of an existing feature WP Admin Issues for the WP Admin screen
2 participants
@swissspidy @ernilambar