Add missing aria-haspopup attribute to the buttons to set and replace the featured image #63360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +21 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5cdfe43. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9876370743
|
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
… the featured image (WordPress#63360) * Add aria-haspopup attribute to featured image buttons. * Improve featured image button labeling. Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: up1512001 <up1512001@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixxes #63359
What?
The buttons to set and replace the featured image do open a dialog but miss to inform screen reader users about it.
Additionally, when the featured image is set, the button aria label only says:
Edit or replace the featured imageThere is no mention anywhere this is the featured image. No heading, no other text.
Why?
it is important to inform users a toggle button will open a dialog.
It is important to calrify this is the post featured image.
How?
Add missing
aria-haspopup="dialog"attribute.When a featured image is set, changes the button aria-label from
Edit or replace the imagetoEdit or replace the featured image.Testing Instructions
Edit or replace the featured image.Testing Instructions for Keyboard
Screenshots or screencast
Before:
After: