Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Featured image button opens a dialog but misses an aria-haspopup attribute #63359

Open
afercia opened this issue Jul 10, 2024 · 0 comments
Open
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 10, 2024

Description

In the Post Summary pael, the Set featured image button does open a dialog. However, it misses an aria-haspopup="dialog" attribute to inform screen reader users it will open a dialog.
Same applies to the 'Replace' button.

Screenshot with Safari and VoiceOver announcing the button. No information is provided about the dialog.

Screenshot 2024-07-10 at 16 17 09

Step-by-step reproduction instructions

  • Use a screen reader.
  • Navigate to the Set featured image button.
  • Observe the button is announced without any meaningful information that is will open a dialog.
  • Set an image.
  • Repeat the test for the 'Replace' button.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Editor /packages/editor labels Jul 10, 2024
@afercia afercia self-assigned this Jul 10, 2024
@afercia afercia changed the title Featured image butons doesn't opens a dialog but misses an aria-haspopup attribute Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
1 participant