Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in column block fixture file #63007

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Jul 1, 2024

What?

Fixes #59145

Why?

As explained in the issue, there's a typo in the file. It doesn't seem to cause any issues as the block parser is fairly relaxed about closing tags in this situation, and still parsed and serialized the block correctly.

How?

Fix the typo. I did also regenerate the fixtures, but they're exactly the same, so there's no changes.

@talldan talldan added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Block] Columns Affects the Columns Block labels Jul 1, 2024
@talldan talldan self-assigned this Jul 1, 2024
Copy link

github-actions bot commented Jul 1, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@talldan talldan requested a review from carolinan July 1, 2024 08:38
@talldan talldan merged commit ae37dc2 into trunk Jul 1, 2024
67 checks passed
@talldan talldan deleted the fix/column-block-fixture-markup branch July 1, 2024 09:54
@github-actions github-actions bot added this to the Gutenberg 18.8 milestone Jul 1, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
Co-authored-by: talldan <talldanwp@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
2 participants