Tests: The column block fixture uses a "columns" closing tag instead of "column"

[carolinan]

Description

The column block fixture is closed with <!-- /wp:columns --> not <!-- /wp:column -->

<!-- wp:column -->
<div class="wp-block-column">
	<!-- wp:paragraph -->
	<p>Column One, Paragraph One</p>
	<!-- /wp:paragraph -->
	<!-- wp:paragraph -->
	<p>Column One, Paragraph Two</p>
	<!-- /wp:paragraph -->
</div>
<!-- /wp:columns -->

Is this intentional?

Step-by-step reproduction instructions

See the linked file above

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[t-hamano]

I believe this is a simple typo 😅

[talldan]

Wow. Should it be failing if it's wrong? 😅

[t-hamano]

Maybe the block parser or something isn't accurate and we might need to look into the root cause.
For example, if I update the closing comment of a paragraph block, the block will still render. However, if you update the content, the closing comment will be corrected automatically 🤔

b3c8d51acf17038baeb6af3ac4cba789.mp4

[talldan]

Maybe the block parser or something isn't accurate and we might need to look into the root cause.

Good point. I seem to recall there is some leniency in how closing tags are parsed. Perhaps it being the only block in the markup helps too.

[carolinan]

What is the correct way of solving it?

This is still causing me a little bit of trouble because I use the fixtures as examples of the block markup in my block reference plugin, and I have visitors reporting that the code is wrong. I understand this is not what the fixture is intended for, but I would rather not have to implement a one-off solution for this single bug in one fixture.
Here is the example page where the code example is displayed https://fullsiteediting.com/blocks/column/

[talldan]

This file can be updated, and then the related files re-generated. There's some instructions in the README.md within that folder explaining how those tests can be updated.

I'll throw together a quick PR that updates it.