-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed page list block text-decoration issue in various theme #62687 #62688
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @viralsampat90! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
I don't think it's a styling issue, it's more that in the editor the links are The main issue with adding an |
There are also some blocks that apply a fake <a href="#post-navigation-pseudo-link">An example title</a> So that's one way of handling it. Thanks for the contribution and making the issue btw! |
What?
The "page list" block is not displaying text-decoration(Underline) on editor, front-end, or both sides. So, I have resolved the issue.
Why?
front-end, or both sides
I think that it should be on both side(Editor & Front-end)
So, I have resolved this issue and added PR.
How?
I have added all the necessary CSS into the block library styles.
Testing Instructions
Testing Instructions for Keyboard
I have made this change on Gutenberg plugin file. After that I have added "block library styles" CSS manually into the inspect element for testing purpose and check this issue for all the themes. It looks good.
Screenshots or screencast
Twenty Ten Theme:
Twenty Twelve Theme:
Twenty Nineteen Theme:
Twenty Twenty-one Theme: