Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the many different theme the "Page List" block not displaying text underline on editor, front-end, or both sides. #62687

Open
viralsampat90 opened this issue Jun 20, 2024 · 2 comments · May be fixed by #62688
Labels
[Block] Page List Affects the Page List Block [Type] Bug An existing feature does not function as intended

Comments

@viralsampat90
Copy link

Description

Hello team,

I have reviewed the "Page List" block on many different themes and I have found that it's text decoration is not appear or not same on editor side & front-end side.

I already added this issue for "Twenty Fourteen" theme #61441, After that I have checked this issue for other themes.

I think that it should be same on both(Editor & Front-end) sides or the text-decoration should have be display based on requirement.

Here, I have provided it's screenshots:

  • WordPress version: WordPress 6.5.4 running,
  • Themes:
    • Twenty Ten Version: 4.1
    • Twenty Twelve Version: 4.2
    • Twenty Nineteen Version: 2.8
    • Twenty Twenty-One Version: 2.2
  • Browser: Google Chrome, Version 126.0.6478.56 (Official Build) (arm64)
  • Device: MacBook Air M1
  • OS: macOS 14.5 (23F79)
  • Gutenberg plugin: Version Version 18.5.0

Thanks,

Step-by-step reproduction instructions

  • Type / to choose a block
  • Select Page List Block
  • Save the changes and publish the page.

Screenshots, screen recording, code snippet

Twenty Ten Theme:

twenty-ten-page-list-editor
twenty-ten-page-list-front-end

Twenty Twelve Theme:

twenty-twelve-page-list-editor
twenty-twelve-page-list-front-end

Twenty Nineteen Theme:

twenty-nineteen-page-list-editor
twenty-nineteen-page-list-front-end

Twenty Twenty-one Theme:

twenty-twenty-one-page-list-editor
twenty-twenty-one-page-list-front-end

Environment info

  • WordPress version: WordPress 6.5.4 running,
  • Themes:
    • Twenty Ten Version: 4.1
    • Twenty Twelve Version: 4.2
    • Twenty Nineteen Version: 2.8
    • Twenty Twenty-One Version: 2.2
  • Browser: Google Chrome, Version 126.0.6478.56 (Official Build) (arm64)
  • Device: MacBook Air M1
  • OS: macOS 14.5 (23F79)
  • Gutenberg plugin: Version Version 18.5.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@viralsampat90 viralsampat90 added the [Type] Bug An existing feature does not function as intended label Jun 20, 2024
viralsampat90 pushed a commit to viralsampat90/gutenberg that referenced this issue Jun 20, 2024
@talldan talldan added the [Block] Page List Affects the Page List Block label Jun 20, 2024
@viralsampat90
Copy link
Author

Hello @talldan

I hope you are doing well.

I have checked above mentioned issue in other themes but they displaying "text-decoration"(Underline) still there is no any href for a tag.

I have checked this issue in below-mentioned themes:

  • Twenty Sixteen Version: 3.2
  • Twenty Seventeen Version: 3.6
  • Twenty Twenty-Two Version: 1.7
  • Twenty Twenty-Three Version: 1.4
  • Twenty Twenty-Four Version: 1.1

Twenty Sixteen:

twenty-sixteen

Twenty Seventeen:

twenty-seventeen

Twenty Twenty-Two:

twenty-twenty-two

Twenty Twenty-Four:

twenty-twenty-four

Note: I already added this issue for "Twenty Fourteen" theme #61441 , After that I have checked this issue for other themes.

Thanks,

@carolinan
Copy link
Contributor

Hi @viralsampat90,
Each of these themes have different styles for links, for example in Twenty Sixteen, there is an editor stylesheet that adds a box shadow to the links, so it is not the default underline that is visible.

@talldan is correct that the best way to solve this is to add the href to the markup in the editor. This will apply the links default browser style, which is to display the underline. Some themes will still need some CSS adjustments after this change.

The proposed CSS change in the linked PR also does not work when the block is placed outside the post content, like in the Site Editor or the widget screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Page List Affects the Page List Block [Type] Bug An existing feature does not function as intended
3 participants