Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Views: Bulk toolbar covering other clickable elements #62333

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Data Views: Bulk toolbar covering other clickable elements #62333

merged 3 commits into from
Jun 6, 2024

Conversation

amitraj2203
Copy link
Contributor

@amitraj2203 amitraj2203 commented Jun 5, 2024 •
edited by ntsekouras
Loading

What?

Fixes: #62228
Fixes: #62227

Why?

Fixes the Bulk toolbar position on scroll. Also fixes the width of it which covers other clickable elements.

How?

Added relevant CSS

Testing Instructions

  1. Go to site editor
  2. Select templates
  3. Ensure you have a theme with enough templates to scroll
  4. Select one or more items so the bulk toolbar appears
  5. Scroll and Scale the browser so the bulk toolbar sits at the same y coordinate as the ellipsis menu for an item in the grid

Testing Instructions for Keyboard

Screenshots or screencast

Screen.Recording.2024-06-05.at.5.46.28.PM.mov
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: amitraj2203 <amitraj2203@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.
ntsekouras
ntsekouras approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!
@ntsekouras ntsekouras added [Type] Bug An existing feature does not function as intended Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Jun 5, 2024
@ntsekouras ntsekouras enabled auto-merge (squash) June 5, 2024 13:48
@ntsekouras ntsekouras merged commit 9d8420f into WordPress:trunk Jun 6, 2024
65 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.6 milestone Jun 6, 2024
ellatrix pushed a commit that referenced this pull request Jun 11, 2024
@amitraj2203 @ellatrix
Data Views: Bulk toolbar covering other clickable elements (#62333)
f9a5698 
* Fix bulk toolbar position on scroll

* fix bulk toolbar taking full width and constraining clicks on elements it overlays
ellatrix pushed a commit that referenced this pull request Jun 11, 2024
@amitraj2203 @ellatrix
Data Views: Bulk toolbar covering other clickable elements (#62333)
f1e9818 
* Fix bulk toolbar position on scroll

* fix bulk toolbar taking full width and constraining clicks on elements it overlays
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
@amitraj2203 @patil-vipul
Data Views: Bulk toolbar covering other clickable elements (WordPress…
9bd6561 
…#62333)

* Fix bulk toolbar position on scroll

* fix bulk toolbar taking full width and constraining clicks on elements it overlays
@ellatrix ellatrix removed the Backport to WP 6.6 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jun 18, 2024
@ellatrix
Copy link
Member

This was cherry-picked to the wp/6.6 branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
3 participants
@amitraj2203 @ellatrix @ntsekouras