Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Block: Improve force page reload modal message #61222

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

colinduwe
Copy link
Contributor

What?

Updates the modal message displayed to users when they insert a non-interactive or non-client-side-navigation compatible block.

Why?

Addresses #60485 in hopes that typical users understand what has happened, how to correct it, and who to reach out to for support.

How?

This now returns a unique list of unsupported block titles when it checks if there are unsupported blocks inside the query block. That is used in the modal message to explain exactly which blocks are preventing the query block from avoiding page refresh navigation.

Testing Instructions

  1. Open a post or page.
  2. Insert a query block
  3. Insert one non-interactive blocks within the query
    core/shortcode is one you might try
    lots of 3rd party blocks do not declare interactivity support
  4. Review the message on the modal.
  5. Insert several non-interactive blocks by inserting a pattern, etc
  6. Review the message on the modal.

Testing Instructions for Keyboard

Testing as above. It should not differ using a pointer device vs keyboard.

Screenshots or screencast

Improve.Query.Modal.Message.mov
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: colinduwe <colind@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Block] Query Loop Affects the Query Loop Block labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Type] Enhancement A suggestion for improvement.
2 participants