Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Block: Improve force page reload modal message #60485

Open
colinduwe opened this issue Apr 4, 2024 · 3 comments
Open

Query Block: Improve force page reload modal message #60485

colinduwe opened this issue Apr 4, 2024 · 3 comments
Labels
[Block] Query Loop Affects the Query Loop Block [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.

Comments

@colinduwe
Copy link
Contributor

What problem does this address?

With the release of the interactivity API, extenders can now create blocks to use inside the query block. We still need to check that any block a user might put inside the query block supports interactivity or client navigation and notify the user. But now the message is getting a little confusing to typical users.

Screenshot 2024-04-04 at 1 51 30 PM

What is your proposed solution?

How can we rewrite this message so it makes at least a little sense to someone who doesn't know about block.supports.interactivity?
First off, I think it would be helpful it we called out the blocks by name that are triggering this modal. Perhaps something like

"The {block.title} was detected inside the query block but that block hasn't declared that it supports avoiding full page reloads. If you still want to prevent full page reloads, remove that {block.title}, then disable "Force page reload" again in the Query Block settings."

@colinduwe colinduwe added the [Type] Enhancement A suggestion for improvement. label Apr 4, 2024
@jordesign jordesign added the [Block] Query Loop Affects the Query Loop Block label Apr 4, 2024
@talldan
Copy link
Contributor

talldan commented Apr 5, 2024

Pinging a couple of contributors who I see have worked on this - @DAreRodz @luisherranz

@colinduwe
Copy link
Contributor Author

This is related to #60006

@annezazu annezazu added the [Type] Copy Issues or PRs that need copy editing assistance label May 1, 2024
@annezazu
Copy link
Contributor

annezazu commented May 1, 2024

Adding the copy tag to see if we can get some editorial thoughts :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.
4 participants