fix: Media & Text block displays video upload errors #59288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the paused state and messaging was implemented for image uploads, it was inadvertently applied to Media & Text blocks. This resulted in a lack of any failed upload messages when a video was attached to the Media & Text block.
dcalhoun
added
[Type] Regression
|
Size Change: -43 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
dcalhoun
added
the
Mobile App - Automation
|
Flaky tests detected in f7cea0c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8008159913
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
derekblank
approved these changes
Feb 22, 2024
dcalhoun
deleted the
fix/media-text-block-displays-video-upload-errors
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix the absence of an error message whenever a video upload for the Media & Text
block fails.
Why?
Fixes #59247. The missing error message leaves the user in a confusing state.
How?
Only enabled the paused media state for image media, which was the original
intent in #56937.
Testing Instructions
Tip
Use a prototype build: iOS or Android.
Testing Instructions for Keyboard
N/A, no changes to the flow included.
Screenshots or screencast
Not provided.