Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message is not displayed when Media & Text block video upload fail #59247

Closed
dcalhoun opened this issue Feb 21, 2024 · 1 comment · Fixed by #59288
Closed

Error message is not displayed when Media & Text block video upload fail #59247

dcalhoun opened this issue Feb 21, 2024 · 1 comment · Fixed by #59288
Assignees
@dcalhoun
Labels
[Block] Media & Text Affects the Media & Text Block Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@dcalhoun
Copy link
Member

Description

If a video upload attached to the Media & Text block fails, no error message is displayed. This means the retry mechanism is not available. A workaround is to remove and re-attach media or remove and re-add the block itself.

Step-by-step reproduction instructions

  1. Add a Media & Text block.
  2. Begin a video upload as the block's media attachment.
  3. Once the upload begins, disable your network connection by turning on airplane mode.

Expected behaviour

A helpful error message is displayed, tapping it provides a "retry" button.

Actual behaviour

The progress bar remains in place without moving. There is no way to retry the video upload.

Screenshots or screen recording (optional)

WordPress information

  • WordPress version: 6.4
  • Gutenberg version: 17.7.0
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes

Device information

  • Device: iPhone SE
  • Operating system: iOS 17.3
  • WordPress app version: 24.1
@dcalhoun dcalhoun added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Block] Media & Text Affects the Media & Text Block labels Feb 21, 2024
@dcalhoun dcalhoun mentioned this issue Feb 21, 2024
Merged
@dcalhoun
Copy link
Member Author

This occurs because we globally enable paused uploads in the Media & Text block. We should conditionally enable them for image media only.

gutenberg/packages/block-library/src/media-text/media-container.native.js

Line 344 in c678e2a

enablePausedUploads

@dcalhoun dcalhoun mentioned this issue Feb 21, 2024
Open
@jordesign jordesign added the [Type] Bug An existing feature does not function as intended label Feb 21, 2024
@dcalhoun dcalhoun mentioned this issue Feb 22, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Media & Text Affects the Media & Text Block Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
2 participants
@dcalhoun @jordesign