Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded margin: 0 override for Notice component consumer #57794

Merged

Conversation

ecgan
Copy link
Contributor

@ecgan ecgan commented Jan 12, 2024

What?

Closes issue #55279.

In this PR, we remove the margin: 0 override for Notice component in the Gutenberg repo.

Why?

This is because the custom margin for the Notice component has been removed in PR #54800, so we don't need to have these margin: 0 override anymore.

How?

Testing Instructions

Important note: I have not figured out a way to test my changes in the code repo in my local machine. I couldn't find documentation on this in the repo. If someone could tell me how to do this in the comment below, that would be great.

  1. Check out this PR.
  2. Run npm install.
  3. Run npm run build. It should complete successfully without any errors.

Testing Instructions for Keyboard

Screenshots or screencast

This is because margin from the Notice component has been removed in PR WordPress#54800.
@draganescu
Copy link
Contributor

I have not figured out a way to test my changes in the code repo in my local machine

Hi @ecgan - you can find plenty of documentation about setting up your local development environment in the developer documentation

@t-hamano t-hamano self-requested a review January 12, 2024 15:38
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! These changes make sense to me, but we would also need to remove the import statements for the scss files that were removed by this PR.

@import "./components/contrast-checker/style.scss";

@t-hamano t-hamano added the [Type] Code Quality Issues or PRs that relate to code quality label Jan 12, 2024
@ecgan
Copy link
Contributor Author

ecgan commented Jan 22, 2024

I have not figured out a way to test my changes in the code repo in my local machine

Hi @ecgan - you can find plenty of documentation about setting up your local development environment in the developer documentation

Hi @draganescu , thanks for the link, but the problem isn't really about setting up my local development environment. It's more about how to test the changes introduced in this PR, and hence how to write the test instructions for this PR. I do not know how I can view and test the CSS code change (for before and after code change).

@ecgan
Copy link
Contributor Author

ecgan commented Jan 22, 2024

These changes make sense to me, but we would also need to remove the import statements for the scss files that were removed by this PR.

@t-hamano , thanks, it slipped my mind. I noticed it caused errors in GitHub Actions. I have fixed it in e17866f (#57794). I have also made sure that npm build works fine in my machine, and updated the test instructions in this PR to mention that.

@t-hamano
Copy link
Contributor

@ecgan Thank you for updating the PR. Is it possible to rebase this PR with the latest trunk branch to merge this PR? Because currently the unit test is failing, but the latest trunk fixes it.

@ecgan
Copy link
Contributor Author

ecgan commented Jan 23, 2024

@t-hamano , thanks for the note. I did a merge in ded5150 (#57794). All checks have passed now.

@t-hamano t-hamano self-requested a review January 23, 2024 13:38
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ecgan Thanks for the update! All GitHub Actions are green, let's merge 👍

@t-hamano t-hamano merged commit 773d03b into WordPress:trunk Jan 23, 2024
55 checks passed
@github-actions github-actions bot added this to the Gutenberg 17.6 milestone Jan 23, 2024
@ecgan ecgan deleted the feature/notice-remove-unneeded-margin-override branch January 23, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
3 participants