Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unneeded style overrides for Notice component #55279

Closed
ecgan opened this issue Oct 11, 2023 · 1 comment
Closed

Clean up unneeded style overrides for Notice component #55279

ecgan opened this issue Oct 11, 2023 · 1 comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.

Comments

@ecgan
Copy link
Contributor

ecgan commented Oct 11, 2023

In PR #54800, we removed the margins for the Notice component.

In #54800 (comment):

I think it would be great to have a small follow-up cleaning any related style overrides (that now are not necessary anymore) like the ones listed in #54800 (comment).

We could look for .components-notice and see what we find.

This issue is a follow-up to the above comment to remove unneeded style override for Notice component.

Here's an example taken from issue #54741 - we should remove the margin override:

image
@ecgan ecgan mentioned this issue Oct 11, 2023
Merged
@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Feature] UI Components Impacts or related to the UI component system labels Oct 11, 2023
@mirka mirka added Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Code Quality Issues or PRs that relate to code quality CSS Styling Related to editor and front end styles, CSS-specific issues. and removed [Feature] UI Components Impacts or related to the UI component system labels Dec 15, 2023
@ecgan ecgan mentioned this issue Jan 12, 2024
Merged
@t-hamano
Copy link
Contributor

Fixed by #57794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.
4 participants
@ecgan @mirka @jordesign @t-hamano