-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Letter Case label name #48613
base: trunk
Are you sure you want to change the base?
Conversation
Fixes #48617 |
Thanks for the PR @SavPhill
Apparently it does not work if I add it in a comment. Can you please add this line to your first message, per our format, so that these get linked. |
Thanks Tom. I will follow this process in future, and have added this to my original detail as instructed in the guidelines: https://make.wordpress.org/core/handbook/best-practices/commit-messages/#ticket-references |
Bumping this reduce the amount of stagnating PR's. Anything else required here or can we approve/reject? @ellatrix |
Thanks for the PR @SavPhill . 'Start Case' would be more appropriate (https://en.wikipedia.org/wiki/Letter_case#Stylistic_or_specialised_usage) as you stated; although I'm not sure whether all of the named capitalized functions in that component should also be renamed? Perhaps a good first step would be just to rename the copy and have a comment in the code that it was formerly called capitalize |
Update Initial Caps to Start Case. Add a Note to explain the change.
Thank you Will. I have updated to 'Start Case' as suggested, and added a one line comment showing that it was previously 'Captalize', to ensure there is no misunderstand. Perhaps we can look at renaming the rest of the code at a different stage. |
Bump to reduce stagnation Any further feedback for this PR? |
Bumping this one again to reduce stagnation. |
If I had to change it I'd choose 'Initial Caps'. That's the term I'm most familiar with. The 'start' in 'start case' could be misconstrued as a verb, and that might lead to problems in localization or even users misunderstanding what the button does. (but if you do go with it, the code could be changed to use I also personally think it's ok as 'Capitalize' though. |
What?
In the Settings Sidebar, the Typography Panel incorrectly labels the letter case where every first word in the sentance is a capital letter, as 'Capitalize'. The correct terminology is either 'Initial Caps' or 'Start Case', as Capitalize is not an official case variation.
Definition: https://www.yourdictionary.com/initial-caps
'Capitalize' case is the wrong label, as it's not an official case terminology and is a vague description of what the case is, which is a starting capital letter on every word.
Fixes #48617.
Why?
The label misrepresents the case.
How?
This fixes the issue by providing the correct label.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast