Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Letter Case Name #48617

Open
SavPhill opened this issue Mar 1, 2023 · 2 comments · May be fixed by #48613
Open

Incorrect Letter Case Name #48617

SavPhill opened this issue Mar 1, 2023 · 2 comments · May be fixed by #48613
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Copy Issues or PRs that need copy editing assistance

Comments

@SavPhill
Copy link
Contributor

SavPhill commented Mar 1, 2023

What problem does this address?

In the Settings Sidebar, the Typography Panel incorrectly labels the letter case where every first word in the sentance is a capital letter, as 'Capitalize'.

image

The correct terminology is either 'Initial Caps' or 'Start Case', as Capitalize is not an official case variation, and doesn't describe the behavior of the output.

What is your proposed solution?

Rename the label to 'Initial Caps' which I have addressed in the following PR:

#48613
@SavPhill SavPhill changed the title Incorrect Name of Case Mar 1, 2023
@SavPhill SavPhill changed the title Incorrect Case Name Mar 1, 2023
@tomdevisser tomdevisser linked a pull request Mar 1, 2023 that will close this issue
Open
@skorasaurus skorasaurus added the [Type] Copy Issues or PRs that need copy editing assistance label Mar 1, 2023
@aristath
Copy link
Member

aristath commented Apr 4, 2023

This is the name of the CSS property: https://developer.mozilla.org/en-US/docs/Web/CSS/text-transform
capitalize makes the 1st letter of the word uppercase.
@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Labelling labels Jul 24, 2023
@richtabor
Copy link
Member

This is the name of the CSS property:

I agree. It's a bit of intersection between type and CSS (could even be "Title casing").

I do think however that "Capitalize" is the sensible approach for typography settings here though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Copy Issues or PRs that need copy editing assistance
6 participants
@aristath @skorasaurus @richtabor @priethor @SavPhill @tomdevisser