Shadow: enable shadow for more blocks #57103
Comments
madhusudhand
added
[Type] Enhancement
This PR adds box shadow support to the following blocks: - Columns - Cover - Group - Image Issue: #57103 * Add shadow support for image block * add shadow support for columns block * add shadow support for individual column block * add shadow support to cover block * fix issue where global shadow isn't applied * revert additional shadow styling for column and columns blocks * fix image block and skip serialization * revert changes related to group block --------- Co-authored-by: vcanales <vcanales@git.wordpress.org> Co-authored-by: madhusudhand <madhudollu@git.wordpress.org> Co-authored-by: dianeco <dianeco@git.wordpress.org>
|
With Column, Columns, and Image support added, I'm going to assume this can be removed from 6.5 with GB 17.7RC1 shipped today. Happy to add back if needed though. |
|
Here's a PR to add shadow support to the Post Featured Image Block |
|
Was there an explicit decision made to exclude the group block this time around? It would seem to be one of the most logical container blocks to include in the first launch. It would be good to understand and communicate the reasoning by only including particular blocks when adding features which make sense globally. |
|
Yes! There was an explicit decision made as you can see in this PR: #57982 TLDR: more testing is needed. |
|
Thanks for the reply, Anne. I can see that testing is needed from that but it’s unclear what issues require more extensive testing than any of the other blocks which now have support. Is the implementation of the control to the group block more complicated than on other containers? Is there any testing I can do which would help? |
This is more or less it. The group and cover block would require changes in the block markup, such as additional wrappers, to make sure that the shadow is rendered correctly and in accordance with the blocks border style. It's not necessarily more complicated, but additional markup wrappers have the potential to introduce regressions down the line. |
|
Thanks for the explanation. Is the necessity because of multiple box shadows? How is that different from a column block? |
|
Hi folks, |
|
The question remains unanswered: why does the addition of box-shadow require additional HTML elements? |
On previous attempts to do this, the cover block was displaying inconsistencies between how it was rendered in the editor vs the frontend; that doesn't seem to be the case anymore, so we should be enable shadow support without any modifications to the block itself. I'd still appreciate some eyes on this, because I don't know what exactly has changed since the first time I attempted this. Tracking issue: #57103
When I initially enabled support for the cover block, there were inconsistencies between what was seen in the editor and what was in the frontend. In particular, the border radius was not being respected by the shadow. I've tried to enable support again without any modifications to the cover block itself, and it seems to be working fine now — no idea what changed! PR: #61883 |
On previous attempts to do this, the cover block was displaying inconsistencies between how it was rendered in the editor vs the frontend; that doesn't seem to be the case anymore, so we should be able to enable shadow support without any modifications to the block itself. I'd still appreciate some eyes on this, because I don't know what exactly has changed since the first time I attempted this. Tracking issue: #57103
On previous attempts to do this, the cover block was displaying inconsistencies between how it was rendered in the editor vs the frontend; that doesn't seem to be the case anymore, so we should be able to enable shadow support without any modifications to the block itself. I'd still appreciate some eyes on this, because I don't know what exactly has changed since the first time I attempted this. Tracking issue: #57103
On previous attempts to do this, the cover block was displaying inconsistencies between how it was rendered in the editor vs the frontend; that doesn't seem to be the case anymore, so we should be able to enable shadow support without any modifications to the block itself. I'd still appreciate some eyes on this, because I don't know what exactly has changed since the first time I attempted this. Tracking issue: #57103
On previous attempts to do this, the cover block was displaying inconsistencies between how it was rendered in the editor vs the frontend; that doesn't seem to be the case anymore, so we should be able to enable shadow support without any modifications to the block itself. I'd still appreciate some eyes on this, because I don't know what exactly has changed since the first time I attempted this. Tracking issue: #57103 Co-authored-by: vcanales <vcanales@git.wordpress.org> Co-authored-by: madhusudhand <madhudollu@git.wordpress.org>
On previous attempts to do this, the cover block was displaying inconsistencies between how it was rendered in the editor vs the frontend; that doesn't seem to be the case anymore, so we should be able to enable shadow support without any modifications to the block itself. I'd still appreciate some eyes on this, because I don't know what exactly has changed since the first time I attempted this. Tracking issue: #57103 Co-authored-by: madhusudhand <madhudollu@git.wordpress.org>
|
With the introduction of the shadow to cover block, marking this issue as complete. |
On previous attempts to do this, the cover block was displaying inconsistencies between how it was rendered in the editor vs the frontend; that doesn't seem to be the case anymore, so we should be able to enable shadow support without any modifications to the block itself. I'd still appreciate some eyes on this, because I don't know what exactly has changed since the first time I attempted this. Tracking issue: WordPress#57103 Co-authored-by: madhusudhand <madhudollu@git.wordpress.org>
On previous attempts to do this, the cover block was displaying inconsistencies between how it was rendered in the editor vs the frontend; that doesn't seem to be the case anymore, so we should be able to enable shadow support without any modifications to the block itself. I'd still appreciate some eyes on this, because I don't know what exactly has changed since the first time I attempted this. Tracking issue: #57103 Co-authored-by: madhusudhand <madhudollu@git.wordpress.org>
On previous attempts to do this, the cover block was displaying inconsistencies between how it was rendered in the editor vs the frontend; that doesn't seem to be the case anymore, so we should be able to enable shadow support without any modifications to the block itself. I'd still appreciate some eyes on this, because I don't know what exactly has changed since the first time I attempted this. Tracking issue: WordPress#57103 Co-authored-by: madhusudhand <madhudollu@git.wordpress.org>
What problem does this address?
As of Gutenberg 17.3, only a button block supports shadow feature. Add support to more blocks.
What is your proposed solution?
Enable the shadow support to following blocks.
Enable for more blocks based on the feedback.
The text was updated successfully, but these errors were encountered: