Add Site Title to Dynamic Block #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this is a dynamic block, we can modify the markup at run time (instead of saving the markup in the database to be displayed). In this case, we are appending the Site Title of the blog to the message being output. If we were to go to Settings > General and modify the "Site Title" setting, the rendered output would change (without our re-opening the post in Gutenberg). See WordPress#203
The Site Title is not modifiable within the block, but if we were to go to Settings > General and modify the "Site Title" value. When we reload the post in Gutenberg, the Site Title would be updated. See WordPress#203
ryanwelcher
requested changes
May 11, 2022
|
Just looks like there are some linting issues to address but after that I think we can merge this! |
|
I'm seeing linting issues, which I will revisit and update this PR. |
|
Linting issues should be resolved now. |
ryanwelcher
approved these changes
May 28, 2022
|
Is there anything else I can do to help get this merged now that the PR is approved? |
|
@salcode thanks for the follow-up! I was assuming that you could merge. At any rate, it's merged, and once again thanks for your contribution 😄 |
|
Ha ha, I appreciate your overestimating my powers 😀 @ryanwelcher Thanks for the merge! Have a great weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I appreciate @ryanwelcher's suggestion on simplifying PR #205
This PR adds the
Site Titleoption value (found atSettings>General)and adds it to the "10-dynamic-block" example.
Front End
In the Editor
Note: In the editor the Site Title (in this case "gutenberg-examples") can not be modified.
Resolves #203