Add post count to dynamic block output #205
Conversation
Add post count to dynamic block output to demonstrate how values can be included in the block output that are updated without updating the post itself. Resolves WordPress#203
There was a problem hiding this comment.
Thank you for taking the time to put this together! Overall, I like the idea I just had a comment on how we're demonstrating how a dynamic block is used to access the database.
My other thought is that whatever example we end up using, we should also update the Edit component to reflect that change as well as most of the example blocks try to match the Block Editor experience with the Front End as closely as possible.
|
|
||
| // Append "on a blog with 27 published posts" | ||
| // where 27 is replaced dynamically with the number of published posts on this blog. | ||
| printf( |
There was a problem hiding this comment.
This is a pretty straightforward example however there is a lot to unpack here.
The usage of printf, the placeholder for the count, wp_count_posts(), that ->publish part should all be explained as we can't assume any knowledge on the part of the person reading this code. See the explanation and links for wp_kses_post above as an example. The output should also be escaped as we're escaping the line above.
Just for argument's sake, we could use a simpler example to demonstrate accessing the database from this block by doing something like:
echo esc_html( get_bloginfo( 'name' ) );or
echo wp_kses_post( $attributes['message'] . ' | ' . get_bloginfo( 'name' ) );
|
This PR is superseded by #216 |
Add post count to dynamic block output to demonstrate how values can be
included in the block output that are updated without updating the post
itself.
Resolves #203
Before PR
After PR
where the number
2is dynamically generated based on how many posts have been published on this blog