Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fatal error on plugin setup #270

Closed
wants to merge 1 commit into from
Closed

Fix fatal error on plugin setup #270

wants to merge 1 commit into from

Conversation

kishanjasani
Copy link

Issue: #269

  • If you forget to run npm run start it will not through fatal error.

Screenshot:
https://prnt.sc/GXp8rMOETYId
@kishanjasani
Fix fatal error on plugin setup
2e8d59b 
- If you forget to run npm run start it throws fatal error
jffng
jffng reviewed Mar 14, 2023
View reviewed changes
Copy link
Contributor

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm if the app has not been built, I think in some ways the fatal error reporting is more useful than showing nothing. Could we provide some messaging / error reporting instead?
@kishanjasani
Copy link
Author

Yes, We can show error/warning message. I will update my pull request.
@matiasbenedetto
Copy link
Contributor

Since the issue motivating this PR doesn't seem to be valid I think we could close this PR. Feel free to re-open if you think we need to implement this.

Thanks for your work trying to improve the plugin! it is very much appreciated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@kishanjasani @matiasbenedetto @jffng