Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fatal Error on plugin setup (PHP 8.0) #269

Closed
kishanjasani opened this issue Mar 10, 2023 · 1 comment
Closed

Fatal Error on plugin setup (PHP 8.0) #269

kishanjasani opened this issue Mar 10, 2023 · 1 comment
Labels
invalid This doesn't seem right

Comments

@kishanjasani
Copy link

How to Replicate:

  1. Clone plugin from repo: git clone git@github.com:WordPress/create-block-theme.git
  2. Run composer install and npm install
  3. If you forget to run npm run start or npm run build
  4. It will throw an error on Apperance -> Manage Theme Fonts

Screenshot:
https://prnt.sc/50oJvHvkyJaQ
@kishanjasani kishanjasani mentioned this issue Mar 10, 2023
Closed
@matiasbenedetto
Copy link
Contributor

Hi, @kishanjasani ! 👋

I think this is the expected behavior (failing if the javascript app is not built yet).

The need to run npm run build is documented here https://github.com/WordPress/create-block-theme/blob/trunk/CONTRIBUTING.md#how-can-i-contribute so I'm closing this issue. Feel free to re-open if you think we should change something around this.
@matiasbenedetto matiasbenedetto added the invalid This doesn't seem right label Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
2 participants
@matiasbenedetto @kishanjasani