Get WordPress

Make WordPress Themes

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#6620 closed theme (not-approved)

THEME: Grisaille - 1.3

Reported by: nudge's profile nudge Owned by: nishasingh's profile nishasingh
Priority: Keywords: theme-grisaille
Cc: nudgeme@…

Description

Grisaille - 1.3

A classic and simple two-column design adjusted for mobile browsing. Latest post will display larger image when inserted with post thumbnail/featured image option. Twitter and Facebook links available via the theme's option page, as well as customizable menu, header image and background. It's pronounced "griz-eye".

Theme URL - ​http://nudgedesign.ca/wordpress-themes/grisaille/
Author URL - ​http://www.nudgedesign.ca

SVN - ​http://themes.svn.wordpress.org/grisaille/1.3
ZIP - ​http://wordpress.org/extend/themes/download/grisaille.1.3.zip?nostats=1

Diff with previous version: ​http://themes.trac.wordpress.org/changeset?old_path=/grisaille/1.2&new_path=/grisaille/1.3

All previous tickets for this theme: ​http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-grisaille&order=id

https://themes.svn.wordpress.org/grisaille/1.3/screenshot.png

Change History (13)

#1 @nishasingh
12 years ago

  • Owner set to nishasingh
  • Status changed from new to accepted

#2 @nishasingh
12 years ago

  • Resolution set to not-approved
  • Status changed from accepted to closed

Theme checker ->

INFO: At least one hard coded date was found in the file archive.php. Consider get_option( 'date_format' )


Unit Test

Layout test->Pass
image test-> pass
Gallery post-> on single gallery post previous and next link is not showing


Single post/page pagination-> previous & next post/page link are not displaying

Code Quality ->

Can you change small <!doctype html> into Caps <!DOCTYPE html> in header.php file.
Can you please explain, for which purpose you are using in header.php file

<ul class="skip">

<li><a href=".menu">Skip to navigation</a></li>
<li><a href="#primaryContent">Skip to main content</a></li>
<li><a href="#secondaryContent">Skip to secondary content</a></li>
<li><a href="#footer">Skip to footer</a></li>

</ul>

#3 @chipbennett
12 years ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#4 @chipbennett
12 years ago

@nishasingh:

Were the observations in your comment the only things you noticed? If so, none of those issues are show-stoppers, so this ticket should not be not-approved based only on those observations.

Also: the previous ticket indicated required issues that needed to be addressed in this version. Were those issues addressed?

#5 @nishasingh
12 years ago

  • Resolution set to approved
  • Status changed from reopened to closed

Sorry @chipbennett for not addressed the previous required issues on this ticket. Now i am addessing all required issues & going to approve this ticket. If i did any mistake please guide me. Thanks for your comment.

Previous required issue ->
Pages should not display a "No comments" message--unless comments are enabled, no comment info should be displayed. - Still Not fixed check ​http://screencast.com/t/I6HBee1V1

#6 @chipbennett
12 years ago

@nishasingh:

No worries; this is a learning process. :)

In this case, while the things you originally noted aren't sufficient to "not-approve" the ticket, the failure to address the previous-ticket required issue is sufficient.

Thanks for your contributions with Theme reviews. If you ever have any questions, don't hesitate to ask!

#7 @chipbennett
12 years ago

  • Resolution approved deleted
  • Status changed from closed to reopened

#8 @chipbennett
12 years ago

  • Resolution set to not-approved
  • Status changed from reopened to closed

Closing as not-approved. Please address previous-ticket required issues, as noted above.

#9 @nudge
12 years ago

Hello nishasingh, Hello Chip,

Can you please clarify the above comment as I believe I have made the necessary changes as required in the previous ticket.

So :

a) are you not seeing the comment modifications I made from the previous version?
b) am I misunderstanding what was needed. Because changes were done to the comments. (also, not clear if the link to the screen shot is sor my theme or not.)

Thanks for clarifying.

#10 @nishasingh
12 years ago

Hello nudge

I have verified your comment modifications, that's why i have add Previous required issue -> Still Not fixed.
For your confirmation (also, not clear if the link to the screen shot is sor my theme or not.) check this ​http://screencast.com/t/kWE0eilHUsXz

Last edited 12 years ago by nishasingh (previous) (diff)

#11 @nudge
12 years ago

Sorry, I'm still not understanding.

Previous ticket (​http://themes.trac.wordpress.org/ticket/6349#comment:2) says:
"Pages should not display a "No comments" message--unless comments are enabled, no comment info should be displayed. - Not fixed. Still displaying "0 comments" and "Sorry, comments are closed" message on Pages."

This is what I fixed.

If I'm misunderstanding, can you please point me to the documentation so I can better understand?

thanks

#12 @chipbennett
12 years ago

Hi Nudge,

Let's step through this:

  1. The page.php template file calls comments_template().
  2. The comments_template() function includes comments.php.
  3. In comments.php, the output of comments_number() is not wrapped in any sort of conditional to prevent it from being output on static pages with comments closed, such as: 
    if ( ! ( is_page() && ! comments_open() ) {
    comments_number(...);
}
  4. Also in comments.php, the output of <?php else : // Comments are closed ?> is similarly not wrapped in a conditional to prevent it from being output on static pages, such as: 
    if ( ! is_page() ) {
    ?>
    <p class="comments-off"><?php _e('Sorry, comments are closed.', 'grisaille'); ?></p>
    <?php
}

Personally, I find it much easier to modify page.php, and only call comments_template() if comments are open, or if the page has comments, like so:

if ( comments_open() || have_comments() ) {
    comments_template();
}

That way, you don't have to worry about where/how you need to add conditional wrappers inside of comments.php.

#13 @nudge
12 years ago

Thanks for the detailed explanation, Chip. I really appreciate it.
And thanks for your patience, nishasingh.

I uploaded a new revised version. Hopefully I got it right this time. :)

Sonia

Note: See TracTickets for help on using tickets.