THEME: Sandalwood – 1.0.3

[shaampk1]

Sandalwood - 1.0.0

Sandalwood is a modern business theme which provides an easy way for individuals and organizations to create a catching presence online. Sandalwood comes with a beautifully crafted front page to engage the audience and also features like custom header images, Advance custom fields, customizable logo and more.

Theme URL - ​http://github.com/ihtishamzahoor/sandalwood/
Author URL - ​http://www.github.com/ihtishamzahoor

Trac Browser - https://themes.trac.wordpress.org/browser/sandalwood/1.0.0

SVN - ​https://themes.svn.wordpress.org/sandalwood/1.0.0
ZIP - ​https://wordpress.org/themes/download/sandalwood.1.0.0.zip?nostats=1

History:

Ticket	Summary	Status	Resolution	Owner
#57633	THEME: Sandalwood – 1.0.3	closed	live	wpedia
(this ticket)
#60662	THEME: Sandalwood – 1.0.4	closed	live	themetracbot
#66139	THEME: Sandalwood – 1.0.5	closed	live	themetracbot
#82550	THEME: Sandalwood – 1.0.6	closed	live	themetracbot
#91436	THEME: Sandalwood – 1.0.7	closed	live	themetracbot
#104017	THEME: Sandalwood – 1.0.8	closed	live	themetracbot
#115186	THEME: Sandalwood – 1.0.9	closed	live	themetracbot

[poena]

Hi!
This is not a complete review -the theme will be fully reviewed once it reaches the top of the queue.
The current waiting time is 5 weeks.
By reducing the number of issues, the review of your theme will be faster.

License, did not pass:
Missing a copyright statement for the theme itself.
License and copyright information is missing for images used in the screenshot.
This license is not correct, you need to include the names of the actual licenses:

• FontAwesome 5 Icon Fonts ​https://fontawesome.com/, (C) 2018 Fonticons, Inc, [Font Awesome Free License] (​https://fontawesome.com/license/free)

Other issues:
-There are parts of underscores that has not been updated for your theme, and any development files like phpcs.xml.dist that needs to be removed.
layouts folder, the lanugauge file, rtl.css, readme files.

Use esc_attr* inside HTML attributes, not esc_html* which is used between HTML tags:
Example
header.php
aria-label="<?php esc_html_e( 'Toggle Navigation', 'sandalwood' ); ?>"

inc/template-tags.php
Do not change the alt text of uploaded images. The theme must respect the user settings, and the user can change the alt text in the media library.

The excerpt_length and excerpt_more filters also affects the admin, so you need to return the default value for the admin, and only use the custom value on the front.

[shaampk1]

Replying to poena:

Hi!
This is not a complete review -the theme will be fully reviewed once it reaches the top of the queue.
The current waiting time is 5 weeks.
By reducing the number of issues, the review of your theme will be faster.

License, did not pass:
Missing a copyright statement for the theme itself.
License and copyright information is missing for images used in the screenshot.
This license is not correct, you need to include the names of the actual licenses:

• FontAwesome 5 Icon Fonts ​https://fontawesome.com/, (C) 2018 Fonticons, Inc, [Font Awesome Free License] (​https://fontawesome.com/license/free)

Other issues:
-There are parts of underscores that has not been updated for your theme, and any development files like phpcs.xml.dist that needs to be removed.
layouts folder, the lanugauge file, rtl.css, readme files.

Use esc_attr* inside HTML attributes, not esc_html* which is used between HTML tags:
Example
header.php
aria-label="<?php esc_html_e( 'Toggle Navigation', 'sandalwood' ); ?>"

inc/template-tags.php
Do not change the alt text of uploaded images. The theme must respect the user settings, and the user can change the alt text in the media library.

The excerpt_length and excerpt_more filters also affects the admin, so you need to return the default value for the admin, and only use the custom value on the front.

Hello @poena!

Thank you so much for your initial review and pin pointing the issues. It's really helpful for me to make this theme upto WordPress Standards. I'll make sure to fix these issues and upload the updated version asap.

Regards,
Shaam

[shaampk1]

Sandalwood first revision

[themetracbot]

Sandalwood - 1.0.1

Sandalwood is a modern theme which provides an easy way for individuals and organizations to create a catching presence online. Sandalwood comes with beautifully crafted sections to engage the audience and includes features like custom header images, customizable logo and more.

Theme URL -
Author URL - ​http://www.github.com/ihtishamzahoor

Trac Browser - https://themes.trac.wordpress.org/browser/sandalwood/1.0.1

SVN - ​https://themes.svn.wordpress.org/sandalwood/1.0.1
ZIP - ​https://wordpress.org/themes/download/sandalwood.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sandalwood/1.0.0&new_path=sandalwood/1.0.1

History:

Ticket	Summary	Status	Resolution	Owner
#57633	THEME: Sandalwood – 1.0.3	closed	live	wpedia
(this ticket)
#60662	THEME: Sandalwood – 1.0.4	closed	live	themetracbot
#66139	THEME: Sandalwood – 1.0.5	closed	live	themetracbot
#82550	THEME: Sandalwood – 1.0.6	closed	live	themetracbot
#91436	THEME: Sandalwood – 1.0.7	closed	live	themetracbot
#104017	THEME: Sandalwood – 1.0.8	closed	live	themetracbot
#115186	THEME: Sandalwood – 1.0.9	closed	live	themetracbot

Theme Check Results:

• RECOMMENDED: Could not find the file readme.txt in the theme. Please see ​Theme_Documentation for more information.

[trtmessenger]

This is a batch message from the Theme Review Team (team leads), please don’t reply to this message.

We just want to let you know that we have a ​program for Trusted Authors and we would like to invite you to read the ​TA requirements and participate.

---

Before you do so, please make sure:

• your theme follows ​all our requirements (check each item in that list and see if it applies to your theme).
• make fewer mistakes.
• you have at least two themes in the directory or one live theme and one in the queue.

---

Some of the advantages of being a Trusted Author:

• as a TA you can submit 1 theme a week, normal authors can submit a theme once every 30 days.
• no review and waiting time, theme goes live in the same day you submit it.

---

Thank you!

[trtmessenger]

This is a batch message.

Hi! We have ​new screenshot requirements, please apply them and make sure your theme doesn’t go live with a faulty screenshot (risking getting your theme suspended).

---

Screenshots are allowed to display only dummy text that doesn’t suggest/describe theme features, functionality, or statistics. If it looks like an AD, then it’s not allowed. Dummy text examples:

• Lorem ipsum (or similar generators)
• Text that doesn’t describe your theme, company, service, or products.

---

​Some nice examples to follow

---

Thank you!

[themetracbot]

Sandalwood - 1.0.2

Sandalwood is a modern theme which provides an easy way for individuals and organizations to create a catching presence online. Sandalwood comes with beautifully crafted sections to engage the audience and includes features like custom header images, customizable logo and more.

Theme URL -
Author URL - ​http://www.github.com/ihtishamzahoor

Trac Browser - https://themes.trac.wordpress.org/browser/sandalwood/1.0.2

SVN - ​https://themes.svn.wordpress.org/sandalwood/1.0.2
ZIP - ​https://wordpress.org/themes/download/sandalwood.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sandalwood/1.0.1&new_path=sandalwood/1.0.2

History:

Ticket	Summary	Status	Resolution	Owner
#57633	THEME: Sandalwood – 1.0.3	closed	live	wpedia
(this ticket)
#60662	THEME: Sandalwood – 1.0.4	closed	live	themetracbot
#66139	THEME: Sandalwood – 1.0.5	closed	live	themetracbot
#82550	THEME: Sandalwood – 1.0.6	closed	live	themetracbot
#91436	THEME: Sandalwood – 1.0.7	closed	live	themetracbot
#104017	THEME: Sandalwood – 1.0.8	closed	live	themetracbot
#115186	THEME: Sandalwood – 1.0.9	closed	live	themetracbot

[wpedia]

Hello there,

There are lot of issues in your theme. Please read the documentation carefully ​http://make.wordpress.org/themes/handbook/review/required/ and fix the issues accordingly. Once you are done then submit the theme again.

Issues are following found in this initial review.

• REQUIRED: Please fix the following issue. Use ​Theme Sniffer plugin for the issues.

  sandalwood/inc/template-tags.php
  17	ERROR	Strings should have translatable content
  45	ERROR	Strings should have translatable content
  

• REQUIRED: No subject tags were found in style.css. Please select minimum 1 and maximum 3 subject tags that reflect your theme. (refer ​https://make.wordpress.org/themes/handbook/review/required/theme-tags/)

• REQUIRED: License, did not pass:

Missing a copyright statement for the theme itself.
License and copyright information is missing for images used in the screenshot.
This license is not correct, you need to include the names of the actual licenses:
FontAwesome 5 Icon Fonts ​https://fontawesome.com/, (C) 2018 Fonticons, Inc, [Font Awesome Free
License] (​https://fontawesome.com/license/free)

• REQUIRED: Your images have 'Unsplash’s License' which is not compatible with GPL. Please replace those images with GPL compatible licensed images (preferable CC0 licensed) and you can follow the format given below,

  Screenshot Image, Copyright Pixabay  
  License: CC0 1.0 Universal (CC0 1.0) 
  Source: https://www.pexels.com/photo/alcohol-architecture-bar-beer-260922/
  

• REQUIRED: Use esc_attr within attribute ( header.php L77 )
• REQUIRED: Remove unnecessary code ( header.php L107-118 )
• REQUIRED: Security did not pass. Use esc_html, esc_attr, esc_url accordingly ​https://codex.wordpress.org/Data_Validation ( template-parts/content-front-page.php )
• REQUIRED: Update the language theme-slug.pot files content

• RECOMMENDED: ​New screenshot requirements , please apply them and make sure your theme doesn’t go live with a faulty screenshot (risking getting your theme suspended).

These are just an example. So don't forgot to check all the themes files and code carefully.

Thanks,
wpedia

[shaampk1]

Replying to wpedia:

Dear wpedia,

Thanks for giving me the opportunity to fix the issues before making any decision. I've resolved most of the issues you mentioned, but with following issues i need your humble direction as to the best of my understandings i have already resolved these issues in the previous update, yet these issues got highlighted during review by you.

1. REQUIRED: License, did not pass:

Missing a copyright statement for the theme itself.
License and copyright information is missing for images used in the screenshot.
This license is not correct, you need to include the names of the actual licenses:
FontAwesome 5 Icon Fonts ​https://fontawesome.com/, (C) 2018 Fonticons, Inc, [Font Awesome Free
License] (​https://fontawesome.com/license/free)

2. RECOMMENDED: ​New screenshot requirements , please apply them and make sure your theme doesn’t go live with a faulty screenshot (risking getting your theme suspended).

Thank you!!!

Regards,
shaam

[wpedia]

Hello shaam,

I have checked again and found that, the first one is my mistake (sorry).

For screenshot:
You can improve the resolution of the screenshot images and make the screenshot a reasonable representation of what the theme can look like. It means using images of a theme should be relevant to the theme name & category.

Since it's in recommended so it's your choice. If you want you can do either or not.

Please resubmit the theme, i will check again. If everything is okay then i will mark as approve and then one of the expert reviewer will review again your theme before goes live.

Thanks,
wpedia

[shaampk1]

Replying to wpedia:

Hi wpedia,

It's totally fine. Things like that happen all the time. Thank you for clearing that up and for your prompt reply. I will upload the updated version of the theme shortly.

Also as New Screenshot Requirements are recommendations i'll keep that on the to-do list for future release and screenshot is 1200x900 resolution so i am positive that there won't be any issue. Thank you for taking the time to review and answer my queries.

Regards,
shaam

[themetracbot]

Sandalwood - 1.0.3

Sandalwood is a modern theme which provides an easy way for individuals and organizations to create a catching presence online. Sandalwood comes with beautifully crafted sections to engage the audience and includes features like flexible-header, custom-background, custom-logo, custom-menu, featured-images and more.

Theme URL -
Author URL - ​http://www.github.com/ihtishamzahoor

Trac Browser - https://themes.trac.wordpress.org/browser/sandalwood/1.0.3

SVN - ​https://themes.svn.wordpress.org/sandalwood/1.0.3
ZIP - ​https://wordpress.org/themes/download/sandalwood.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=sandalwood/1.0.2&new_path=sandalwood/1.0.3

History:

Ticket	Summary	Status	Resolution	Owner
#57633	THEME: Sandalwood – 1.0.3	closed	live	wpedia
(this ticket)
#60662	THEME: Sandalwood – 1.0.4	closed	live	themetracbot
#66139	THEME: Sandalwood – 1.0.5	closed	live	themetracbot
#82550	THEME: Sandalwood – 1.0.6	closed	live	themetracbot
#91436	THEME: Sandalwood – 1.0.7	closed	live	themetracbot
#104017	THEME: Sandalwood – 1.0.8	closed	live	themetracbot
#115186	THEME: Sandalwood – 1.0.9	closed	live	themetracbot

[wpedia]

Hello shaam,

I have approved the theme. Now one of the senior reviewer will review again.

Thanks,
wpedia

[shaampk1]

Replying to wpedia:

Hello,

Thank you so very much wpedia. I am sure and all excited that the final review won't take much time to approve as well.

Regards,
shaam

[wponlinesupport]

Hello @shaampk1

Please fix your theme issue in next update.

• REQUIRED: Copyright should be in this format under readme.txt file

  Sandalwood WordPress Theme, Copyright 2018 Ihtisham Zahoor
  Sandalwood is distributed under the terms of the GNU GPL
  

• bootstrap_js should be just bootstrap under function.php file L176

Approving and setting live. It will take around 1 hour for theme to appear in the directory.