THEME: Linden Lite – 1.0.3

[nudge]

Linden Lite - 1.0

Give your site a classic and elegant look with Linden Lite’s clean and minimal design. Highlight your top post, page or portfolio item with the featured post section. The homepage is designed to show your latest posts or use the custom template to set your front page as your portfolio.

Theme URL - ​http://themes.nudgethemes.com/linden-lite/
Author URL - ​http://nudgethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/linden-lite/1.0

SVN - ​https://themes.svn.wordpress.org/linden-lite/1.0
ZIP - ​https://wordpress.org/themes/download/linden-lite.1.0.zip?nostats=1

History:

Ticket	Summary	Status	Resolution	Owner
#51589	THEME: Linden Lite – 1.0.3	closed	live	rabmalin
(this ticket)

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

[wponlinesupport]

Hello @nudge,

Note: This is not a full review.

Your theme will be reviewed when your theme reaches to the top of the Review Queue and review process will follow procedures found in the Theme Handbook. Please check it thoroughly and fix your theme accordingly. If 3 or more distinct issues are found, ticket could be closed as not approved.

In the mean time, please check following issues.

Issues

• REQUIRED:Your theme name is Linden Lite so all function name should start with linden_lite prefix Eg : linden_lite_setup() instead of linden_setup()

• REQUIRED: Escaping missing - Whenever you use get_theme_mod() value for display, it should be escaped properly.

• Check your theme comments.php file and replace the below code from L26 to L34

  <?php
  <h4 class="comments-title">
                          <?php
                                  $comments_number = get_comments_number();
                                  if ( '1' === $comments_number ) {
                                          /* translators: %s: post title */
                                          printf( _x( 'One thought on &ldquo;%s&rdquo;', 'comments title', 'linden-lite' ), get_the_title() );
                                  } else {
                                          printf(
                                                  /* translators: 1: number of comments, 2: post title */
                                                  _nx(
                                                          '%1$s thought on &ldquo;%2$s&rdquo;',
                                                          '%1$s thoughts on &ldquo;%2$s&rdquo;',
                                                          $comments_number,
                                                          'comments title',
                                                          'linden-lite'
                                                  ),
                                                  number_format_i18n( $comments_number ),
                                                  get_the_title()
                                          );
                                  }
                          ?>
                  </h4>
  

• Hard-coded links were found in the file start-page.php

• Take batter care if featured image not added : ​https://screenshots.firefox.com/e9j7Lzj8Nb3Y8XZN/localhost

• Test all WordPress widgets with Monster Widget : ​https://wordpress.org/plugins/monster-widget/

[themetracbot]

Linden Lite - 1.0.1

Give your site a classic and elegant look with Linden Lite’s clean and minimal design. Highlight your top post, page or portfolio item with the featured post section. The homepage is designed to show your latest posts or use the custom template to set your front page as your portfolio.

Theme URL - ​http://themes.nudgethemes.com/linden-lite/
Author URL - ​http://nudgethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/linden-lite/1.0.1

SVN - ​https://themes.svn.wordpress.org/linden-lite/1.0.1
ZIP - ​https://wordpress.org/themes/download/linden-lite.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=linden-lite/1.0&new_path=linden-lite/1.0.1

History:

Ticket	Summary	Status	Resolution	Owner
#51589	THEME: Linden Lite – 1.0.3	closed	live	rabmalin
(this ticket)

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

[nudge]

New version uploaded. It addresses points 1,2 and 3.

4. Hard-coded links were found in the file start-page.php The links in the file lead to theme docs and upgrade page. Please provide additional info on how to proceed with this if this isn't correct.

5 .Take batter care if featured image not added: ​https://screenshots.firefox.com/e9j7Lzj8Nb3Y8XZN/localhost The screenshot shows expected result. Please provide additional information as to what behaviour you are anticipating. Or provided a clearer screenshot.

Thanks.

[DannyCooper]

Hi @nudge,

template-portfolio.php - $intro_title_box is not escaped.
Same in index.php
archive.php:21 - this could be esc_html_e to be consistent with the rest of your code.
extras.php - the theme mods going into body_class need to be escaped.
You may want to remove linden_wp_title() as we are past 4.3 now.
customizer.php - typically empty values shouldn't be translatable:

'default'			=> esc_html__('', 'linden-lite' ),

Thanks for contributing your theme!

[themetracbot]

Linden Lite - 1.0.2

Give your site a classic and elegant look with Linden Lite’s clean and minimal design. Highlight your top post, page or portfolio item with the featured post section. The homepage is designed to show your latest posts or use the custom template to set your front page as your portfolio.

Theme URL - ​http://themes.nudgethemes.com/linden-lite/
Author URL - ​http://nudgethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/linden-lite/1.0.2

SVN - ​https://themes.svn.wordpress.org/linden-lite/1.0.2
ZIP - ​https://wordpress.org/themes/download/linden-lite.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=linden-lite/1.0.1&new_path=linden-lite/1.0.2

History:

Ticket	Summary	Status	Resolution	Owner
#51589	THEME: Linden Lite – 1.0.3	closed	live	rabmalin
(this ticket)

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

[nudge]

Hi there,

Thanks for the review!

1. template-portfolio.php - $intro_title_box is not escaped. Same in index.php
These are already escaped. Take a look at line 31 and 33 of each file respectively.

2.archive.php:21 - this could be esc_html_e to be consistent with the rest of your code.
This has been fixed.

3. extras.php - the theme mods going into body_class need to be escaped.
This is already being sanitized using a function. See customizer.php line 135

4. You may want to remove linden_wp_title() as we are past 4.3 now.
This has been fixed.

5.customizer.php - typically empty values shouldn't be translatable:

 'default'                       => esc_html__('', 'linden-lite' ),

This has been fixed.

Thanks!

[DannyCooper]

Great!

[nudge]

Hi @DannyCooper,

Thanks for approving the theme!

Do you know how long before it gets put live? I'm seeing themes that were submitted later than ours which are already live so curious what the process is.

Thanks!

[rabmalin]

Hello,

Please fix following issues and re-upload your theme.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Issues

• REQUIRED: Theme URL is invalid. ​https://make.wordpress.org/themes/handbook/review/required/#selling-credits-and-links
• REQUIRED: PHP version - You can support any PHP version you want. You just need to make sure that, theme does not generate fatal error in lower PHP versions. If user's PHP version is lower than your theme required, your theme should implement graceful fallback and revert system to older theme. If you implement this, you dont need to fix sniffer errors (given below) generated due to PHP version.
• REQUIRED: Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc. ​http://themereview.co/prefix-all-the-things/ Since you are using linden-lite as theme slug, please make prefixing uniform in all places. function enqueue_scripts() should be function linden_lite_enqueue_scripts(). Check all files thoroughly.
• REQUIRED: Image size handle should be prefixed.
• REQUIRED: Widget title should be passed through widget_title filter with parameters instance and id base. Ref: ​https://core.trac.wordpress.org/browser/trunk/src/wp-includes/widgets/class-wp-widget-text.php
• REQUIRED: Please implement proper sanitization for values when saved to database. ​https://codex.wordpress.org/Data_Validation#Input_Validation Eg, sanitize_text_field() should be used to sanitize text field, esc_url_raw for URL field, for sanitizing field with HTML tags, use wp_kses_post() for sanitization, use absint() to sanitize positive integer. Check sanitization in Customizer and also in update() in widgets.

Important

Before re-submitting themes, please check ​Theme Review Guidelines very thoroughly. Also, test your theme with following plugins.

• ​Theme Check
• ​Theme Sniffer - Errors need to be fixed and Warnings are things that need to be checked manually.

Theme Check Sniffs

Note: Errors need to be fixed and Warnings are things that need to be checked manually.

FILE: /var/www/review.dev/public_html/wp-content/themes/linden-lite/functions.php
---------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------
 290 | ERROR | Only variables can be passed to empty() prior to PHP 5.5.
---------------------------------------------------------------------------------

Time: 25413522 mins, 16.57 secs; Memory: 4Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/linden-lite/inc/admin/start-page/start-page.php
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
 43 | ERROR | [x] Multiple placeholders should be ordered. Expected '%1$1s, %2$2s', but got %1s, %2s.
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------

Time: 25413522 mins, 16.7 secs; Memory: 2Mb

FILE: ...w/review.dev/public_html/wp-content/themes/linden-lite/inc/nudge-upgrade-theme/add-customize-section.php
--------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------
 15 | ERROR | The function get_called_class() is not present in PHP version 5.2 or earlier
 18 | ERROR | The function get_called_class() is not present in PHP version 5.2 or earlier
--------------------------------------------------------------------------------------------------------------

Time: 25413522 mins, 16.85 secs; Memory: 2Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/linden-lite/inc/template-tags.php
-----------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------
 131 | ERROR | Strings should have translatable content
 149 | ERROR | Strings should have translatable content
 169 | ERROR | Strings should have translatable content
-----------------------------------------------------------------------------------------

Time: 25413522 mins, 17.01 secs; Memory: 2Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/linden-lite/index.php
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
 29 | ERROR | Only variables can be passed to empty() prior to PHP 5.5.
-----------------------------------------------------------------------------

Time: 25413522 mins, 17.05 secs; Memory: 2Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/linden-lite/single.php
------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------
 41 | ERROR | Only variables can be passed to empty() prior to PHP 5.5.
 52 | ERROR | Only variables can be passed to empty() prior to PHP 5.5.
------------------------------------------------------------------------------

Time: 25413522 mins, 17.38 secs; Memory: 2Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/linden-lite/template-parts/content-featured-posts.php
-------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 15 | ERROR | Short array syntax (open) is available since 5.4
 15 | ERROR | Short array syntax (close) is available since 5.4
-------------------------------------------------------------------------------------------------------------

Time: 25413522 mins, 17.42 secs; Memory: 2Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/linden-lite/template-parts/content.php
----------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
 12 | ERROR | Short array syntax (open) is available since 5.4
 12 | ERROR | Short array syntax (close) is available since 5.4
----------------------------------------------------------------------------------------------

Time: 25413522 mins, 17.62 secs; Memory: 2Mb

FILE: /var/www/review.dev/public_html/wp-content/themes/linden-lite/template-portfolio.php
------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------
 27 | ERROR | Only variables can be passed to empty() prior to PHP 5.5.
------------------------------------------------------------------------------------------

[themetracbot]

Linden Lite - 1.0.3

Give your site a classic and elegant look with Linden Lite’s clean and minimal design. Highlight your top post, page or portfolio item with the featured post section. The homepage is designed to show your latest posts or use the custom template to set your front page as your portfolio.

Theme URL - ​http://themes.nudgethemes.com/linden-lite/
Author URL - ​http://nudgethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/linden-lite/1.0.3

SVN - ​https://themes.svn.wordpress.org/linden-lite/1.0.3
ZIP - ​https://wordpress.org/themes/download/linden-lite.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=linden-lite/1.0.2&new_path=linden-lite/1.0.3

History:

Ticket	Summary	Status	Resolution	Owner
#51589	THEME: Linden Lite – 1.0.3	closed	live	rabmalin
(this ticket)

Theme Check Results:

• RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

[nudge]

Hi,

• REQUIRED: Theme URL is invalid. --> I'm following the handbook guidelines and not clear on what is the issue. Can you please clarify?

• The rest of the issues listed have been fixed.

Thanks.

[rabmalin]

Isnt it pointing to the theme demo?

If the URI is a demo site, the content must be about the theme itself and not test data.

[nudge]

Exactly. It is pointing to a demo site and the content is about the theme itself and what it can do. Not test data.

[rabmalin]

Sorry but I dont find enough information about theme in the site.

[jcastaneda]

@rabmalin what kind of information were you thinking or were looking for from the author?

Sorry, I was asked to take a look over this. I, personally, feel like this one is a somewhat trivial issue and shouldn't prevent it from being set live only because this can be addressed via many iterations. Some themes like to add features down the line, some remove them. :)

[rabmalin]

Setting live.