THEME: Grisaille - 1.0

[nudge]

Grisaille - 1.0

A classic and simple two-column design adjusted for mobile browsing. Latest post will display larger image when inserted with post thumbnail/featured image option. Twitter and Facebook links available via the theme's option page, as well as customizable menu, header image and background. It's pronounced "griz-eye".

Theme URL - ​http://nudgedesign.ca/wordpress-themes/grisaille/
Author URL - ​http://www.nudgedesign.ca

SVN - ​http://themes.svn.wordpress.org/grisaille/1.0
ZIP - ​http://wordpress.org/extend/themes/download/grisaille.1.0.zip?nostats=1

All previous tickets for this theme: ​http://themes.trac.wordpress.org/query?keywords=~theme-grisaille

[nudge]

Hi,

I see my theme is till waiting for approval. It has now been two months. Is this normal?

Thanks!
Sonia

[selenas]

Required

• Move wp_footer directly before closing body tag in footer.php
• Fix validation error on line 6 of home.php - there is whitespace in the id.
• Use a unique slug as a prefix for all custom functions - please see functions.php which have functions with generic names. It is recommended to use the theme-name as the slug.
• Favicon functionality has been added - it is required to be opt-in and disabled by default and also required to support user-defined favicon images.
• There are a couple issues with the nav menu. First, you don't need the add_theme_support('menus') function, register_nav_menu handles that. Second, your call to wp_nav_menu in header.php does not include theme_location so only the first menu available by default can be used. Please add theme_location to the array so users will be able to select from multiple menus. See ​Function Reference wp_nav_menu
• Support for editor stylesheet has been added in functions.php but there is no additional stylesheet found. Please either add the stylesheet or remove the function.
• Post without a title must display a link to the single post view - See ​Theme Unit Test

Recommended

• While running the theme check plugin there were several files with textdomain problems. For example, in single.php you have <?php the_content(__('keep reading')); ?> and no textdomain is specified. Either remove these strings or add localization support.
• Remove the feed URLs from header.php, they are not needed since automatic_feed_links is being used.
• Use the get_search_form include in 404.php instead of adding in a form.
• There is a bug with the custom background function - when changing to just a background color the original background remains. See ​Custom background fix for more information.
• Issue with the_tags function used in multiple files - there is a ',' before the first tag.
• There is no need to check if the register_sidebar and dynamic_sidebar functions exist, they've been around long enough that they can be used safely without checking for backwards compatibility.

Styling Issues
There are some styling issues that are apparent when going though the Theme Unit test:

• The dl, dt, and dd tags are not styled.
• Unordered list (ul) hangs over the content area on the left side.
• Make sure floated images are properly cleared - again refer to the Theme Unit test.
• Linked images that are larger than the content area overflows, make sure they are properly resized.
• Check the display of list items (ul, ol) within comments, they are not displayed properly.

Overall
This theme is not ready to be approved yet. Please go through the required and recommended fixes and resubmit once they have been fixed.

[emiluzelac]

Hi,

We have been super busy lately and sorry about that. One of us will look over the comments above and act accordingly.

[chipbennett]

Closing as not-approved as per the reviewers recommendation.