Get WordPress

Make WordPress Themes

Opened 8 years ago

Closed 7 years ago

#38925 closed theme (live)

THEME: Brilliant – 1.0.7

Reported by: fabiorubioglio's profile fabiorubioglio Owned by: rabmalin's profile rabmalin
Priority: previously reviewed Keywords: theme-brilliant
Cc: designlabthemes@…

Description

Brilliant - 1.0.1

Brilliant is a beautiful and stylish WordPress magazine and blog theme.

Theme URL - ​https://www.designlabthemes.com/brilliant-wordpress-theme/
Author URL - ​https://www.designlabthemes.com/

SVN - ​https://themes.svn.wordpress.org/brilliant/1.0.1
ZIP - ​https://wordpress.org/themes/download/brilliant.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=brilliant/1.0.0&new_path=brilliant/1.0.1

History:

Ticket Summary Status Resolution Owner
#35491 THEME: Brilliant – 1.0.0 closed not-approved poena
#38925 THEME: Brilliant – 1.0.7 closed live rabmalin

(this ticket)
#41938 THEME: Brilliant – 1.0.8 closed live themetracbot
#43639 THEME: Brilliant – 1.0.9 closed live themetracbot
#44534 THEME: Brilliant – 1.1.0 closed live themetracbot
#47336 THEME: Brilliant – 1.1.1 closed live themetracbot
#48730 THEME: Brilliant – 1.1.2 closed live themetracbot
#50550 THEME: Brilliant – 1.1.3 closed live themetracbot
#56440 THEME: Brilliant – 1.1.4 closed live themetracbot
#64870 THEME: Brilliant – 1.1.5 closed live themetracbot
#83387 THEME: Brilliant – 1.1.6 closed live themetracbot
#86467 THEME: Brilliant – 1.1.7 closed live themetracbot
#92776 THEME: Brilliant – 1.1.8 closed live themetracbot
#107765 THEME: Brilliant – 1.1.9 closed live themetracbot
#125902 THEME: Brilliant – 1.2.0 closed live themetracbot
#159386 THEME: Brilliant – 1.2.1 closed live themetracbot


https://themes.svn.wordpress.org/brilliant/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

Change History (20)

#1 @themetracbot
7 years ago

  • Summary changed from THEME: Brilliant – 1.0.1 to THEME: Brilliant – 1.0.2

Brilliant - 1.0.2

Brilliant is a beautiful and stylish WordPress magazine and blog theme.

Theme URL - ​https://www.designlabthemes.com/brilliant-wordpress-theme/
Author URL - ​https://www.designlabthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/brilliant/1.0.2

SVN - ​https://themes.svn.wordpress.org/brilliant/1.0.2
ZIP - ​https://wordpress.org/themes/download/brilliant.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=brilliant/1.0.1&new_path=brilliant/1.0.2

History:

Ticket Summary Status Resolution Owner
#35491 THEME: Brilliant – 1.0.0 closed not-approved poena
#38925 THEME: Brilliant – 1.0.7 closed live rabmalin

(this ticket)
#41938 THEME: Brilliant – 1.0.8 closed live themetracbot
#43639 THEME: Brilliant – 1.0.9 closed live themetracbot
#44534 THEME: Brilliant – 1.1.0 closed live themetracbot
#47336 THEME: Brilliant – 1.1.1 closed live themetracbot
#48730 THEME: Brilliant – 1.1.2 closed live themetracbot
#50550 THEME: Brilliant – 1.1.3 closed live themetracbot
#56440 THEME: Brilliant – 1.1.4 closed live themetracbot
#64870 THEME: Brilliant – 1.1.5 closed live themetracbot
#83387 THEME: Brilliant – 1.1.6 closed live themetracbot
#86467 THEME: Brilliant – 1.1.7 closed live themetracbot
#92776 THEME: Brilliant – 1.1.8 closed live themetracbot
#107765 THEME: Brilliant – 1.1.9 closed live themetracbot
#125902 THEME: Brilliant – 1.2.0 closed live themetracbot
#159386 THEME: Brilliant – 1.2.1 closed live themetracbot


https://themes.svn.wordpress.org/brilliant/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#2 @themetracbot
7 years ago

  • Summary changed from THEME: Brilliant – 1.0.2 to THEME: Brilliant – 1.0.3

Brilliant - 1.0.3

Brilliant is a beautiful and stylish WordPress magazine and blog theme.

Theme URL - ​https://www.designlabthemes.com/brilliant-wordpress-theme/
Author URL - ​https://www.designlabthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/brilliant/1.0.3

SVN - ​https://themes.svn.wordpress.org/brilliant/1.0.3
ZIP - ​https://wordpress.org/themes/download/brilliant.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=brilliant/1.0.2&new_path=brilliant/1.0.3

History:

Ticket Summary Status Resolution Owner
#35491 THEME: Brilliant – 1.0.0 closed not-approved poena
#38925 THEME: Brilliant – 1.0.7 closed live rabmalin

(this ticket)
#41938 THEME: Brilliant – 1.0.8 closed live themetracbot
#43639 THEME: Brilliant – 1.0.9 closed live themetracbot
#44534 THEME: Brilliant – 1.1.0 closed live themetracbot
#47336 THEME: Brilliant – 1.1.1 closed live themetracbot
#48730 THEME: Brilliant – 1.1.2 closed live themetracbot
#50550 THEME: Brilliant – 1.1.3 closed live themetracbot
#56440 THEME: Brilliant – 1.1.4 closed live themetracbot
#64870 THEME: Brilliant – 1.1.5 closed live themetracbot
#83387 THEME: Brilliant – 1.1.6 closed live themetracbot
#86467 THEME: Brilliant – 1.1.7 closed live themetracbot
#92776 THEME: Brilliant – 1.1.8 closed live themetracbot
#107765 THEME: Brilliant – 1.1.9 closed live themetracbot
#125902 THEME: Brilliant – 1.2.0 closed live themetracbot
#159386 THEME: Brilliant – 1.2.1 closed live themetracbot


https://themes.svn.wordpress.org/brilliant/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#3 @themetracbot
7 years ago

  • Summary changed from THEME: Brilliant – 1.0.3 to THEME: Brilliant – 1.0.4

Brilliant - 1.0.4

Brilliant is a beautiful and stylish WordPress magazine and blog theme.

Theme URL - ​https://www.designlabthemes.com/brilliant-wordpress-theme/
Author URL - ​https://www.designlabthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/brilliant/1.0.4

SVN - ​https://themes.svn.wordpress.org/brilliant/1.0.4
ZIP - ​https://wordpress.org/themes/download/brilliant.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=brilliant/1.0.3&new_path=brilliant/1.0.4

History:

Ticket Summary Status Resolution Owner
#35491 THEME: Brilliant – 1.0.0 closed not-approved poena
#38925 THEME: Brilliant – 1.0.7 closed live rabmalin

(this ticket)
#41938 THEME: Brilliant – 1.0.8 closed live themetracbot
#43639 THEME: Brilliant – 1.0.9 closed live themetracbot
#44534 THEME: Brilliant – 1.1.0 closed live themetracbot
#47336 THEME: Brilliant – 1.1.1 closed live themetracbot
#48730 THEME: Brilliant – 1.1.2 closed live themetracbot
#50550 THEME: Brilliant – 1.1.3 closed live themetracbot
#56440 THEME: Brilliant – 1.1.4 closed live themetracbot
#64870 THEME: Brilliant – 1.1.5 closed live themetracbot
#83387 THEME: Brilliant – 1.1.6 closed live themetracbot
#86467 THEME: Brilliant – 1.1.7 closed live themetracbot
#92776 THEME: Brilliant – 1.1.8 closed live themetracbot
#107765 THEME: Brilliant – 1.1.9 closed live themetracbot
#125902 THEME: Brilliant – 1.2.0 closed live themetracbot
#159386 THEME: Brilliant – 1.2.1 closed live themetracbot


https://themes.svn.wordpress.org/brilliant/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#4 @rabmalin
7 years ago

  • Owner set to rabmalin
  • Status changed from new to reviewing

#5 @rabmalin
7 years ago

Hello,

Please reupload your theme after fixing issues. ​https://wordpress.org/themes/upload/

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Issues

  • REQUIRED: Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, image size, etc. ​http://themereview.co/prefix-all-the-things/
  • REQUIRED: comments.php L31 - Missing singular placeholder, needed for some languages. See ​https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals See Twenty Seventeen for reference.
  • REQUIRED: Remove search-form from add_theme_support( 'html5'.
  • REQUIRED: Make sure excerpt_length and excerpt_more filter does not affect admin side. See Twenty Seventeen theme for reference.
  • REQUIRED: Escaping missing. Check brilliant_excerpt_length()
  • REQUIRED: Change date ('Y') to date_i18n(__('Y','textdomain'))
  • REQUIRED: Credits and license: Update readme file to keep credits and license info of all third party resources. Sample format: ​https://make.wordpress.org/themes/2015/04/29/a-revised-readme/ Eg, images (used in the screenshot) URL missing.
  • REQUIRED: Remove post-formats theme tag and related code as theme does not seem to implement Post Formats.
  • REQUIRED: Translation issue - customizer.php L31. Please check in other places also.

#6 @fabiorubioglio
7 years ago

hi @rabmalin,
thank you for the review.
only one question about post-formats tag.
the theme gives a "clear visual distinction" to post formats: it displays an icon over the featured image, if present.
could you please reconsider this?

#7 @rabmalin
7 years ago

May be you need to add icon independent of featured image. Use may have no featured image in their site. In that case Post Formats does not make sense. If you do not agree we can ping key reviewer for second opinion. Let me know what do you think.

#8 @fabiorubioglio
7 years ago

i agree with you.
if it's possible, i would keep css code (we can consider this as a plus, if user has featured images) and remove post-formats tag.

#9 @fabiorubioglio
7 years ago

@rabmalin,
my theme xmag was approved by key admin @poena, with post-formats tag and the same logic (an icon over featured images).

#10 @rabmalin
7 years ago

@fabiorubioglio You can remove tag and keep style for now. And fix all other issues. Lets wait for @poena opinion here. If she agrees, then you can add theme tag.

#11 @fabiorubioglio
7 years ago

@rabmalin,
ok, thanks!

#12 @poena
7 years ago

Hi
I did a test run and have no issues with how the post formats are used.

#13 @themetracbot
7 years ago

  • Summary changed from THEME: Brilliant – 1.0.4 to THEME: Brilliant – 1.0.5

Brilliant - 1.0.5

Brilliant is a beautiful and stylish WordPress magazine and blog theme.

Theme URL - ​https://www.designlabthemes.com/brilliant-wordpress-theme/
Author URL - ​https://www.designlabthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/brilliant/1.0.5

SVN - ​https://themes.svn.wordpress.org/brilliant/1.0.5
ZIP - ​https://wordpress.org/themes/download/brilliant.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=brilliant/1.0.4&new_path=brilliant/1.0.5

History:

Ticket Summary Status Resolution Owner
#35491 THEME: Brilliant – 1.0.0 closed not-approved poena
#38925 THEME: Brilliant – 1.0.7 closed live rabmalin

(this ticket)
#41938 THEME: Brilliant – 1.0.8 closed live themetracbot
#43639 THEME: Brilliant – 1.0.9 closed live themetracbot
#44534 THEME: Brilliant – 1.1.0 closed live themetracbot
#47336 THEME: Brilliant – 1.1.1 closed live themetracbot
#48730 THEME: Brilliant – 1.1.2 closed live themetracbot
#50550 THEME: Brilliant – 1.1.3 closed live themetracbot
#56440 THEME: Brilliant – 1.1.4 closed live themetracbot
#64870 THEME: Brilliant – 1.1.5 closed live themetracbot
#83387 THEME: Brilliant – 1.1.6 closed live themetracbot
#86467 THEME: Brilliant – 1.1.7 closed live themetracbot
#92776 THEME: Brilliant – 1.1.8 closed live themetracbot
#107765 THEME: Brilliant – 1.1.9 closed live themetracbot
#125902 THEME: Brilliant – 1.2.0 closed live themetracbot
#159386 THEME: Brilliant – 1.2.1 closed live themetracbot


https://themes.svn.wordpress.org/brilliant/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#14 @fabiorubioglio
7 years ago

hi @rabmalin,
in the version 1.0.5 we added links and up sell button to the customizer (we used customize pro by Justin Tadlock)

#15 @rabmalin
7 years ago

Issues

  • REQUIRED: Invalid prefix DL_Important_Links
  • REQUIRED: Credits and license: Update readme file to keep credits and license info of all third party resources. Sample format: ​https://make.wordpress.org/themes/2015/04/29/a-revised-readme/ Eg, images (used in the screenshot) URL missing. There are three images used in the screenshot.
  • REQUIRED: You are using 'type' => 'option' for several theme options. Please use theme mod.

#16 @themetracbot
7 years ago

  • Summary changed from THEME: Brilliant – 1.0.5 to THEME: Brilliant – 1.0.6

Brilliant - 1.0.6

Brilliant is a beautiful and stylish WordPress magazine and blog theme.

Theme URL - ​https://www.designlabthemes.com/brilliant-wordpress-theme/
Author URL - ​https://www.designlabthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/brilliant/1.0.6

SVN - ​https://themes.svn.wordpress.org/brilliant/1.0.6
ZIP - ​https://wordpress.org/themes/download/brilliant.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=brilliant/1.0.5&new_path=brilliant/1.0.6

History:

Ticket Summary Status Resolution Owner
#35491 THEME: Brilliant – 1.0.0 closed not-approved poena
#38925 THEME: Brilliant – 1.0.7 closed live rabmalin

(this ticket)
#41938 THEME: Brilliant – 1.0.8 closed live themetracbot
#43639 THEME: Brilliant – 1.0.9 closed live themetracbot
#44534 THEME: Brilliant – 1.1.0 closed live themetracbot
#47336 THEME: Brilliant – 1.1.1 closed live themetracbot
#48730 THEME: Brilliant – 1.1.2 closed live themetracbot
#50550 THEME: Brilliant – 1.1.3 closed live themetracbot
#56440 THEME: Brilliant – 1.1.4 closed live themetracbot
#64870 THEME: Brilliant – 1.1.5 closed live themetracbot
#83387 THEME: Brilliant – 1.1.6 closed live themetracbot
#86467 THEME: Brilliant – 1.1.7 closed live themetracbot
#92776 THEME: Brilliant – 1.1.8 closed live themetracbot
#107765 THEME: Brilliant – 1.1.9 closed live themetracbot
#125902 THEME: Brilliant – 1.2.0 closed live themetracbot
#159386 THEME: Brilliant – 1.2.1 closed live themetracbot


https://themes.svn.wordpress.org/brilliant/1.0.6/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#17 @rabmalin
7 years ago

One final issue remaining.

Issues

  • REQUIRED: You are using 'type' => 'option' for several theme options. -- Still remaining accent_color and footer_bg. Please check it.

#18 @themetracbot
7 years ago

  • Summary changed from THEME: Brilliant – 1.0.6 to THEME: Brilliant – 1.0.7

Brilliant - 1.0.7

Brilliant is a beautiful and stylish WordPress magazine and blog theme.

Theme URL - ​https://www.designlabthemes.com/brilliant-wordpress-theme/
Author URL - ​https://www.designlabthemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/brilliant/1.0.7

SVN - ​https://themes.svn.wordpress.org/brilliant/1.0.7
ZIP - ​https://wordpress.org/themes/download/brilliant.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=brilliant/1.0.6&new_path=brilliant/1.0.7

History:

Ticket Summary Status Resolution Owner
#35491 THEME: Brilliant – 1.0.0 closed not-approved poena
#38925 THEME: Brilliant – 1.0.7 closed live rabmalin

(this ticket)
#41938 THEME: Brilliant – 1.0.8 closed live themetracbot
#43639 THEME: Brilliant – 1.0.9 closed live themetracbot
#44534 THEME: Brilliant – 1.1.0 closed live themetracbot
#47336 THEME: Brilliant – 1.1.1 closed live themetracbot
#48730 THEME: Brilliant – 1.1.2 closed live themetracbot
#50550 THEME: Brilliant – 1.1.3 closed live themetracbot
#56440 THEME: Brilliant – 1.1.4 closed live themetracbot
#64870 THEME: Brilliant – 1.1.5 closed live themetracbot
#83387 THEME: Brilliant – 1.1.6 closed live themetracbot
#86467 THEME: Brilliant – 1.1.7 closed live themetracbot
#92776 THEME: Brilliant – 1.1.8 closed live themetracbot
#107765 THEME: Brilliant – 1.1.9 closed live themetracbot
#125902 THEME: Brilliant – 1.2.0 closed live themetracbot
#159386 THEME: Brilliant – 1.2.1 closed live themetracbot


https://themes.svn.wordpress.org/brilliant/1.0.7/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#19 @fabiorubioglio
7 years ago

hi @rabmalin,
i fixed the last issue.
thank you for the review.

#20 @rabmalin
7 years ago

  • Resolution set to live
  • Status changed from reviewing to closed

Looks good. Approving and setting live. It will take around 1 hour for theme to appear in the directory. Good luck!

Note: See TracTickets for help on using tickets.