THEME: Simple Perle – 1.0.1

[nudge]

Simple Perle - 1.0

With a name that suggests beauty and refinement, Simple Perle gives your site a perfectly polished look. Easy to setup, this theme lets you display your three newest Portfolio projects as well as your latest blog posts, all on the default front-page layout. Simple Perle is the perfect theme for anyone wanting to display portrait images using a magazine design.

Theme URL - ​http://themes.nudgethemes.com/simple-perle
Author URL - ​http://nudgethemes.com

SVN - ​https://themes.svn.wordpress.org/simple-perle/1.0
ZIP - ​https://wordpress.org/themes/download/simple-perle.1.0.zip?nostats=1

History:

Ticket	Summary	Status	Resolution	Owner
#34078	THEME: Simple Perle – 1.0.1	closed	live	acosmin
(this ticket)
#39292	THEME: Simple Perle – 1.0.2	closed	live	themetracbot
#43012	THEME: Simple Perle – 1.0.3	closed	live	themetracbot

[milana_cap]

Hello,
your theme will very soon be assigned to reviewer and checked against these requirements: ​https://make.wordpress.org/themes/handbook/review/required/

Considering it was last updated 5 months ago, please make sure it meets all the requirements and is compatible with latest WordPress version. Keep in mind that ticket will be closed as not-approved if theme has more than 5 distinct required issues.

If you have any questions, do come to slack and ask away
​https://wordpress.slack.com/messages/themereview/

[acosmin]

Hi! I'll be reviewing your theme mostly based on this ​guideline.

Required

1. functions.php
   • lines 44-46, those handles need a prefix
   • remove
     • line 72, you already have a custom searchform in searchform.php
   • simple_perle_scripts() - not really required at the momment, but 3rd party styles/scripts don't need prefixes
     • simple-perle-font-awesome-css should be just font-awesome
       • also, don't add -css at the end, Core already does this.
   • screenReaderText needs a prefix
   • line 257, replace ... with …
   • replace simple_perle_pagination() and the parts where it's used with the_post_pagination(). It does the same thing and has all those arguments.

2. Themes are not allowed to require plugins to work. Just recommend.
   • The Jetpack plugin is required to use some of this theme’s features, including: Portfolios (Custom Content Types module). Please activate Jetpack by WordPress.com. Activate
     • Also, this message needs to be dismissable, at the moment it's not, try and click on the little x

3. inc\customizer.php
   • simple_melody_customize_upgrade() this type of advertising is no longer allowed, try this instead:
     • ​https://github.com/justintadlock/trt-customizer-pro

4. Remove any development files/folders
   • sass folder, you can add this as a separate download file on your website.

5. readme.txt
   • Fontawesome has a double license

6. Your Theme URL needs to display information about the theme, currently it's a demo

---

You have 7 days, after that I will need to close the ticket.
I don't like to repeat myself, so please take your time and make the changes.
If you have any question or if you want a second opinion from an admin, join the ​Slack ​channel

Thank you!

[acosmin]

1 more day

[nudge]

Yes, thanks. I appreciate the work you do but reminder not required. ;) I've been waiting 5 months. I think a few extra days wouldn't be an issue here considering all feedback is minor.

That being said, I've been working on the changes. New version will be uploaded shortly.

Thanks!

[themetracbot]

Simple Perle - 1.0.1

With a name that suggests beauty and refinement, Simple Perle gives your site a perfectly polished look. Easy to setup, this theme lets you display your three newest Portfolio projects as well as your latest blog posts, all on the default front-page layout. Simple Perle is the perfect theme for anyone wanting to display portrait images using a magazine design.

Theme URL - ​https://nudgethemes.com/wordpress-themes/perle-theme/
Author URL - ​http://nudgethemes.com

SVN - ​https://themes.svn.wordpress.org/simple-perle/1.0.1
ZIP - ​https://wordpress.org/themes/download/simple-perle.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=simple-perle/1.0&new_path=simple-perle/1.0.1

History:

Ticket	Summary	Status	Resolution	Owner
#34078	THEME: Simple Perle – 1.0.1	closed	live	acosmin
(this ticket)
#39292	THEME: Simple Perle – 1.0.2	closed	live	themetracbot
#43012	THEME: Simple Perle – 1.0.3	closed	live	themetracbot

[nudge]

Hi again,

New version uploaded. All points addressed except the following:

1. functions.php

   • simple_perle_scripts() - not really required at the momment, but 3rd party styles/scripts don't need prefixes

Not exactly sure what you mean with this statement, plus following Twentysixteen's lead (and all Automattic themes), all scripts and styles are prefixed. Left this in as this is not required nor a show-stopper.

Thanks again for your time in reviewing the theme!

[acosmin]

If I would not have warned you about it, you would've gone berserk on me tomorrow, asking me why I closed it without warning :)

Anyway, everything looks fine, you have a typo in the Administration panel - "Theme Sart Page"

What I meant by that statement is that the handles for 3rd party scripts used in simple_perle_scripts() don't need prefixes. FontAwesome for example, doesn't need a prefix - simple-perle-font-awesome should be font-awesome. It's a recommendation, it helps to avoid loading assets twice (if a plugin enqueues the same asset but with a different handle).

Congrats, your theme should be live shortly!