THEME: Liquorice - 1.5.6

[nudge]

Liquorice - 1.5.6

A simple and clean vintage looking theme for you to build on using Google's font API Lobster font. Custome background and custom header features enabled.

Theme URL - ​http://www.nudgedesign.ca/wordpress-themes/liquorice
Author URL - ​http://www.nudgedesign.ca

SVN - ​http://themes.svn.wordpress.org/liquorice/1.5.6
ZIP - ​http://wordpress.org/extend/themes/download/liquorice.1.5.6.zip?nostats=1

Diff with previous version: ​http://themes.trac.wordpress.org/changeset?old_path=/liquorice/1.5.5&new_path=/liquorice/1.5.6

All previous tickets for this theme: ​http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-liquorice&order=priority

[Fingli]

=> This version produces several warning messages

• => Warning: Missing argument 1 for add_custom_image_header(), called in C:\xampplite\htdocs\wp\wp-content\themes\liquorice\functions.php on line 25 and defined in C:\xampplite\htdocs\wp\wp-includes\theme.php on line 1400

• => Warning: Missing argument 2 for add_custom_image_header(), called in C:\xampplite\htdocs\wp\wp-content\themes\liquorice\functions.php on line 25 and defined in C:\xampplite\htdocs\wp\wp-includes\theme.php on line 1400

Notices
=> Undefined variable: admin_header_callback in C:\xampplite\htdocs\wp\wp-includes\theme.php on line 1409
=> Undefined offset: 0 in C:\xampplite\htdocs\wp\wp-includes\plugin.php on line 747
=> Undefined offset: 0 in C:\xampplite\htdocs\wp\wp-includes\plugin.php on line 765
=> Use of undefined constant HEADER_TEXTCOLOR - assumed 'HEADER_TEXTCOLOR' in C:\xampplite\htdocs\wp\wp-admin\custom-header.php on line 448
=> Use of undefined constant HEADER_TEXTCOLOR - assumed 'HEADER_TEXTCOLOR' in C:\xampplite\htdocs\wp\wp-admin\custom-header.php on line 448
=> Use of undefined constant HEADER_TEXTCOLOR - assumed 'HEADER_TEXTCOLOR' in C:\xampplite\htdocs\wp\wp-admin\custom-header.php on line 451
=> Use of undefined constant HEADER_IMAGE_WIDTH - assumed 'HEADER_IMAGE_WIDTH' in C:\xampplite\htdocs\wp\wp-admin\custom-header.php on line 464
=> Use of undefined constant HEADER_IMAGE_HEIGHT - assumed 'HEADER_IMAGE_HEIGHT' in C:\xampplite\htdocs\wp\wp-admin\custom-header.php on line 464

Suggestion for future improvement
/ get_bloginfo('url') was found in the file functions.php. Use home_url() instead

Line 55: $output .= '<a href=''  . get_bloginfo('url') . ''>' . get_bloginfo('name') . '</a>

---

This is a tertiary review. Next reviewer might find more so please do everything you can to adhere to the documentation on what is accepted in the theme review.

• Developer needs to thoroughly read the ​Theme Review and find all the must-haves and update their theme(s) accordingly, this theme will continue to not pass until all requirements are met.
• It's useful if the authors check their themes with ​Theme-Check plugin and with set WP_DEBUG to 'true' in wp-config.php

Items marked with => are reasons for not being approved
Items marked with / are just suggestions
Items marked with - are notes

Once the points above have been addressed appropriately using the available information found at the links above; please thoroughly review your theme and re-submit it using the uploader tool: ​http://wordpress.org/extend/themes/upload/ this will generate a new Trac ticket.

---

Responding To This Review

Theme developer questions, comments, and feedback are welcome and encouraged. Please use one of the following methods:

1) Leave a comment on this ticket
2) Email the theme-reviewers email list
3) Use the #wordpress-themes channel on irc.freenode.net (or through ​http://webchat.freenode.net/)

[nudge]

Hi,

Your warning paths are for your local WP install and not my theme.
Ex :
C:\xampplite\htdocs\wp\wp-includes\theme.php <=== Not my theme.
C:\xampplite\htdocs\wp\wp-admin\custom-header.php <=== Not my theme.

Etc...

Can you please review your comments before I dig into this?

Thanks!

[Fingli]

Replying to nudge:
Hi,
Yes, your theme DOES these errors. It's not necessary they to be from theme's files, your theme calls and corresponds with those core WP files.
Check your theme with set WP_DEBUG to 'true' in wp-config.php and you will see them all (there are even more which I omitted in purpose to shorten the review)

Hi,

Your warning paths are for your local WP install and not my theme.
Ex :
C:\xampplite\htdocs\wp\wp-includes\theme.php <=== Not my theme.
C:\xampplite\htdocs\wp\wp-admin\custom-header.php <=== Not my theme.

Etc...

Can you please review your comments before I dig into this?

Thanks!