Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid links from external resources #509

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

itzmekhokan
Copy link
Contributor

@itzmekhokan itzmekhokan commented Jun 6, 2024

In WP CLI Handbook External Resources, there has below invalid links -

Slides > Kelly Dwan: Importing (any!) Content with WP-CLI

Videos > AJ Morris: Managing WordPress from the Command Line

With this PR it should change with below links that should be as below and also change some http:// resourses ink -

Slides > Kelly Dwan: Importing (any!) Content with WP-CLI

Videos > AJ Morris: Managing WordPress from the Command Line

@itzmekhokan itzmekhokan requested a review from a team as a code owner June 6, 2024 04:59
@ernilambar
Copy link
Member

@itzmekhokan Thanks for the PR. While we are at external resources page, can you please check all other links in this page also? https://make.wordpress.org/cli/handbook/guides/external-resources/ Looks like there are still http:// links which are now converted to https://.

@itzmekhokan
Copy link
Contributor Author

@ernilambar, yes there are some link with http://, I have updated external resources. Please check the PR.

Copy link
Member

@thelovekesh thelovekesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the updated links are working as expected.

@thelovekesh thelovekesh merged commit 90e42d2 into wp-cli:main Jun 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants