Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visibility in command class methods #423

Merged
merged 1 commit into from
May 1, 2024
Merged

Fix visibility in command class methods #423

merged 1 commit into from
May 1, 2024

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Apr 30, 2024 •
edited
Loading

Introduced in #421

  • Change method visibility from public to private

When kept public, cmd_dump() was taking those as commands which should not be. https://github.com/ernilambar/wpcli/blob/main/src/manifest.json#L4442
@ernilambar ernilambar marked this pull request as ready for review April 30, 2024 05:42
@ernilambar ernilambar requested a review from a team as a code owner April 30, 2024 05:42
@swissspidy swissspidy added this to the 2.1.21 milestone Apr 30, 2024
@swissspidy swissspidy added the bug label Apr 30, 2024
thelovekesh
thelovekesh requested changes Apr 30, 2024
View reviewed changes
src/WP_CLI/CommandWithUpgrade.php Outdated Show resolved Hide resolved
@ernilambar ernilambar force-pushed the fix-command-method-visibility branch from 6679828 to ae73b80 Compare April 30, 2024 06:46
@thelovekesh thelovekesh merged commit 23fe646 into wp-cli:main May 1, 2024
38 checks passed
@ernilambar ernilambar deleted the fix-command-method-visibility branch May 1, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug
3 participants
@ernilambar @swissspidy @thelovekesh