Apply check_package() on bulk_upgrade #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the check_package() function to the "upgrader_source_selection" filter hook. This applies the check for PHP minimum version number before "bulk" updating a plugin. Note: A "bulk" upgrade occurs even when a single plugin is updated, e.g. the following uses the "bulk" upgrade code wp plugin update gutenberg Resolves wp-cli#357
|
Thanks for diving into this, @salcode ! It looks like the issue is fixed in trunk now, and may be backported to earlier versions of WordPress. The upstream fix is most appropriate, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this as a Draft PR for reference, as these changes should resolve #357
However, I believe this is a WordPress core issue and have opened Trac Ticket 59198 in the hopes it can be resolved there.
Add the check_package() function to the
"upgrader_source_selection" filter hook.
This applies the check for PHP minimum version number
before "bulk" updating a plugin.
Note: A "bulk" upgrade occurs even when a single plugin is updated,
e.g. the following uses the "bulk" upgrade code
wp plugin update gutenberg
Resolves #357