Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace current outline algorithm with one based on heading levels #7829

Merged
merged 45 commits into from
Jul 1, 2022
Merged

replace current outline algorithm with one based on heading levels #7829

merged 45 commits into from
Jul 1, 2022

Commits on Apr 17, 2022

  1. removed outline algorithm 

    The CSS UA styles partial implementation has been left as is
https://html.spec.whatwg.org/multipage/rendering.html#sections-and-headings

Why partial? refer to https://codepen.io/stevef/pen/ZEvmNPg
    @stevefaulkner
    stevefaulkner committed Apr 17, 2022
    Configuration menu
    Copy the full SHA
    1065688 View commit details
    Browse the repository at this point in the history

  2. clarify allowed content of hgroup 

    response to whatwg#7829 (review)
    @stevefaulkner
    stevefaulkner committed Apr 17, 2022
    Configuration menu
    Copy the full SHA
    f86c397 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2022

  1. updated headings and sections 

    used modified text of @annevk PR headings and sections section whatwg#3499
    @stevefaulkner
    stevefaulkner committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    e96100f View commit details
    Browse the repository at this point in the history

  2. removed sectioning root concept 

    general clean up and closer alignment with @annevk PR whatwg#3499
    @stevefaulkner
    stevefaulkner committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    7ffe0bd View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. fixed conflict

    @stevefaulkner
    stevefaulkner committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    6b5cc4c View commit details
    Browse the repository at this point in the history

  2. another fix?

    @stevefaulkner
    stevefaulkner committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    0d2fa7b View commit details
    Browse the repository at this point in the history

  3. added return h1 

    after feedback from @mtrootyy whatwg#7829 (review)
    @stevefaulkner
    stevefaulkner committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    3d23dab View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Fix build errors

    @sideshowbarker
    sideshowbarker committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    88bc37a View commit details
    Browse the repository at this point in the history

  2. Fix markup error caught by HTML checker 

    This error seems to have been introduced in f5def65,
whatwg#7475 — so it’s unclear why CI didn’t
catch it there.
    @sideshowbarker
    sideshowbarker committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    f5f3917 View commit details
    Browse the repository at this point in the history

  3. Revert markup change that added p element in hgroup 

    Changing the spec source markup to use a p element in hgroup will need
to wait until after the spec change lands.
    @sideshowbarker
    sideshowbarker committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    d7a8d50 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. several clarifications 

    a document is conforming without a h1, but it is not recommended.
a document is conforming without a h1 as the first heading in the DOM, but it is not recommended.
sectioning content does not effect heading levels, but authors are encouraged to match heading level and sectioning content nesting level.
Thanks to @mtrootyy for feedback
    @stevefaulkner
    stevefaulkner committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    5b3e474 View commit details
    Browse the repository at this point in the history

  2. fix linting errors

    @stevefaulkner
    stevefaulkner committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    09e8490 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'whatwg:main' into outline-reality-reset

    @stevefaulkner
    stevefaulkner committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    0327b04 View commit details
    Browse the repository at this point in the history

  4. remove rank in reference to headings

    @stevefaulkner
    stevefaulkner committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    71cd1d1 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. WIP Some updates based on code review 

    - updated in response to whatwg#7829 (comment)
- added hgroup back with a caveat whatwg#7829 (comment)
- added back in response to whatwg#7829 (comment)
- updated in response to whatwg#7829 (comment)
    @stevefaulkner
    stevefaulkner committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    cce4797 View commit details
    Browse the repository at this point in the history

  2. fix linting error

    @stevefaulkner
    stevefaulkner committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    4b5a5d3 View commit details
    Browse the repository at this point in the history

  3. remove mention of CSS sticky 

    - update in response to whatwg#7829 (comment)
    @stevefaulkner
    stevefaulkner committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    91f864c View commit details
    Browse the repository at this point in the history

  4. restored hr note 

    - in response to whatwg#7829 (comment)
    @stevefaulkner
    stevefaulkner committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    7ac1373 View commit details
    Browse the repository at this point in the history

  5. removed Generic 

    - in response to whatwg#7829 (comment)
    @stevefaulkner
    stevefaulkner committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    0fbbc0d View commit details
    Browse the repository at this point in the history

  6. replace document headings with outline 

    - in response to whatwg#7829 (comment)
    @stevefaulkner
    stevefaulkner committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    817c59a View commit details
    Browse the repository at this point in the history

  7. fix lint error

    @stevefaulkner
    stevefaulkner committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    b2207d3 View commit details
    Browse the repository at this point in the history

  8. added back heading content category 

    in response to whatwg#7829 (review)
    @stevefaulkner
    stevefaulkner committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    03d27be View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Zap trailing whitespace (unbreak CI)

    @sideshowbarker
    sideshowbarker committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    b595cbd View commit details
    Browse the repository at this point in the history

  2. update hgroup content model 

    in response to whatwg#7829 (comment)
    @stevefaulkner
    stevefaulkner committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    5f7ae31 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. replaced important term 

    in response to
- whatwg#7829 (comment)
- whatwg#7829 (review)
    @stevefaulkner
    stevefaulkner committed May 2, 2022
    Configuration menu
    Copy the full SHA
    0c07285 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. Minor editorial fixes

    @domenic
    domenic committed May 3, 2022
    Configuration menu
    Copy the full SHA
    e841164 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. updated example and svg 

    in response to whatwg#7829 (comment)
    @stevefaulkner
    stevefaulkner committed May 4, 2022
    Configuration menu
    Copy the full SHA
    5543e9c View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. reworked hgroup definition 

    in response to https://github.com/whatwg/html/pull/7829/files/d7a8d508f2ef794f7dbdfba5f0472a4dbc2a5800#r859004921
    @stevefaulkner
    stevefaulkner committed May 5, 2022
    Configuration menu
    Copy the full SHA
    0096441 View commit details
    Browse the repository at this point in the history

  2. added back header clarification 

    in response to https://github.com/whatwg/html/pull/7829/files/d7a8d508f2ef794f7dbdfba5f0472a4dbc2a5800#r859007333
    @stevefaulkner
    stevefaulkner committed May 5, 2022
    Configuration menu
    Copy the full SHA
    efbe168 View commit details
    Browse the repository at this point in the history

  3. add example 

    - lint fix
- grammatical fix
- outline example in response to https://github.com/whatwg/html/pull/7829/files/d7a8d508f2ef794f7dbdfba5f0472a4dbc2a5800#r859016942
    @stevefaulkner
    stevefaulkner committed May 5, 2022
    Configuration menu
    Copy the full SHA
    8c1cb5e View commit details
    Browse the repository at this point in the history

  4. added example 

    in response to https://github.com/whatwg/html/pull/7829/files/d7a8d508f2ef794f7dbdfba5f0472a4dbc2a5800#r859016942
    @stevefaulkner
    stevefaulkner committed May 5, 2022
    Configuration menu
    Copy the full SHA
    2242b9d View commit details
    Browse the repository at this point in the history

  5. removed trailing whitespace

    @stevefaulkner
    stevefaulkner committed May 5, 2022
    Configuration menu
    Copy the full SHA
    2d0b9bb View commit details
    Browse the repository at this point in the history

Commits on May 8, 2022

  1. Merge branch 'main' into outline-reality-reset

    @stevefaulkner
    stevefaulkner committed May 8, 2022
    Configuration menu
    Copy the full SHA
    5754ddd View commit details
    Browse the repository at this point in the history

  2. various updates 

    - added sectioning root back, but only for body element.

- updated acc considerations for header/footer
-- whatwg#7829 (comment)
whatwg#7829 (review)
    @stevefaulkner
    stevefaulkner committed May 8, 2022
    Configuration menu
    Copy the full SHA
    045cf00 View commit details
    Browse the repository at this point in the history

  3. lint fix

    @stevefaulkner
    stevefaulkner committed May 8, 2022
    Configuration menu
    Copy the full SHA
    d07cf54 View commit details
    Browse the repository at this point in the history

  4. typo fix

    @stevefaulkner
    stevefaulkner committed May 8, 2022
    Configuration menu
    Copy the full SHA
    ea5492b View commit details
    Browse the repository at this point in the history

  5. removed note 

    in response to whatwg#7829 (comment)
    @stevefaulkner
    stevefaulkner committed May 8, 2022
    Configuration menu
    Copy the full SHA
    559d70b View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2022

  1. Minor fixes

    @domenic
    domenic committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    052efb0 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Attempt to fix remaining review comments

    @domenic
    domenic committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    becd7b3 View commit details
    Browse the repository at this point in the history

  2. This link no longer seems relevant

    @domenic
    domenic committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    a1b9930 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. Updates from zcorpan's review

    @domenic
    domenic committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    9014ace View commit details
    Browse the repository at this point in the history

  2. Remove "sectioning root" again

    @domenic
    domenic committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    71928c0 View commit details
    Browse the repository at this point in the history

  3. Add back "Exposing outlines to users"; various example tweaks

    @domenic
    domenic committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    de7ac7b View commit details
    Browse the repository at this point in the history

  4. Fix extra "ancestor"

    @domenic
    domenic committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    a7004a9 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Add missing "None" for td category

    @domenic
    domenic committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    dd81361 View commit details
    Browse the repository at this point in the history