Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Fix incorrect heading level in example #10095

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Editorial: Fix incorrect heading level in example #10095

merged 3 commits into from
Feb 2, 2024

Conversation

MarcusOtter
Copy link
Contributor

@MarcusOtter MarcusOtter commented Jan 26, 2024

The heading levels in this example are not valid after the outline algorithm changes, because it contains two <h1> tags. This PR changes the 2nd <h1> to an <h2> which should be semantically correct in this example.


/acknowledgements.html ( diff )
/sections.html ( diff )

@MarcusOtter
Copy link
Contributor Author

MarcusOtter commented Jan 26, 2024

Sidenote, the contributing guidelines state that:

Please add your name to the Acknowledgments section (search for <!-- ACKS) in your first pull request, even for trivial fixes.

I assumed this also includes trivial editorial fixes, happy to remove that line if not.

source Show resolved Hide resolved
@annevk annevk merged commit bf21a30 into whatwg:main Feb 2, 2024
2 checks passed
@annevk
Copy link
Member

annevk commented Feb 2, 2024

Thanks @MarcusOtter!

@MarcusOtter MarcusOtter deleted the heading-level-example-fix branch May 1, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants