Fix #91. Make all pointer events composed events #92
Conversation
|
as I'm not completely au-fait with what composed events actually are/do, nor if there are any issues with a W3C spec referencing WHATWG (political or otherwise) ... @RByers, thoughts? |
|
I suggest we wait until UIEvents has been updated for this before trying to review a PR for PointerEvents (since we mostly just copy the patterns from UI Events here). |
|
PR for UI events has been merged w3c/uievents#91. |
| @@ -393,7 +394,7 @@ | |||
| <h2>Firing events using the <code>PointerEvent</code> interface</h2> | |||
| <p>To <dfn>fire a pointer event name e</dfn> means to <dfn>fire an event named e</dfn> as defined in [[!DOM4]] with an event using the <a>PointerEvent</a> interface whose attributes are set as defined in <a href="#pointerevent-interface"><code>PointerEvent</code> Interface</a>.</p> | |||
|
|
|||
| <p>Initialize the <code>bubbles</code> attribute for the event to <code>true</code> if the event name is</p> | |||
| <p>Initialize the <code>bubbles</code> attribute and the <code>composed</code> [[!WHATWG-DOM]] attribute for the event to <code>true</code> if the event name is</p> | |||
There was a problem hiding this comment.
The below list doesn't include pointerenter or pointerleave but you want those to be composed, right? I suggest moving the text for composed up to the above sentence so that it applies to all pointer events.
|
Oh, this is non-trivial enough that you should probably also add an entry to the revision history. |
All pointer events should propagate across Shadow DOM bounaries. See WICG/webcomponents#513 for details.
Thanks! I have added an entry to the revision history. I have squashed the commits. Could you review PR again? |
|
LGTM |
All pointer events should propagate across Shadow DOM bounaries.
See WICG/webcomponents#513 for details.