Add boundary events in implicit capture scenarios #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.html
Outdated
| for the <code>pointerId</code> of the <code>pointerup</code> or <code>pointercancel</code> event that was just dispatched, | ||
| and then run <a href="#process-pending-pointer-capture">Process Pending Pointer Capture</a> steps to fire <code>lostpointercapture</code> if necessary. | ||
| After running <a href="#process-pending-pointer-capture">Process Pending Pointer Capture</a> steps, | ||
| if the pointer supports hover user agent MUST also send corresponding boundary events if necessary to reflect the current position of the pointer with no capture. |
There was a problem hiding this comment.
"pointer supports hover, the user agent MUST"
index.html
Outdated
| @@ -837,7 +837,14 @@ <h2><dfn>Implicit Pointer Capture</dfn></h2> | |||
| </section> | |||
| <section> | |||
| <h3>Implicit Release of Pointer Capture</h3> | |||
| <p>Immediately after firing the <code>pointerup</code> or <code>pointercancel</code> events, a user agent MUST clear the <a>pending pointer capture target override</a> for the <code>pointerId</code> of the <code>pointerup</code> or <code>pointercancel</code> event that was just dispatched, and then run <a href="#process-pending-pointer-capture">Process Pending Pointer Capture</a> steps to fire <code>lostpointercapture</code> if necessary.</p> | |||
| <p> | |||
There was a problem hiding this comment.
a minor thing, but maybe worth not leaving <p> and </p> hanging on their own lines
mustaqahmed
approved these changes
Apr 25, 2018
index.html
Outdated
| and then run <a href="#process-pending-pointer-capture">Process Pending Pointer Capture</a> steps to fire <code>lostpointercapture</code> if necessary. | ||
| After running <a href="#process-pending-pointer-capture">Process Pending Pointer Capture</a> steps, | ||
| if the pointer supports hover, user agent MUST also send corresponding boundary events if necessary | ||
| to reflect the current position of the pointer with no capture. </p> | ||
| <p>If the user agent supports firing the <code>click</code> event (see <a title="compatibility mouse events" href="#dfn-compatibility-mouse-events">compatibility mouse events</a>) and if in an implicit release scenario both <code>click</code> and <code>lostpointercapture</code> events are fired, <code>click</code> should be fired before <code>lostpointercapture</code>.</p> | ||
| <p>When the <a>pointer capture target override</a> is removed from its <code>ownerDocument</code>'s tree, | ||
| clear the <a>pending pointer capture target override</a> and <a>pointer capture target override</a> nodes |
There was a problem hiding this comment.
Bike-shedding on an old text, sorry: the imperative verb only in this para looks odd. Could you please change it too? Something like:
the pending pointer capture target override and pointer capture target override nodes should be cleared and also a lostpointercapture event corresponding to the captured pointer should be fired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #173