Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace prose about ownerDocument tree with DOM4 concept of connected #246

Merged
merged 4 commits into from
Apr 3, 2018
Merged

Replace prose about ownerDocument tree with DOM4 concept of connected #246

merged 4 commits into from
Apr 3, 2018

Conversation

patrickhlauke
Copy link
Member

Closes #221

@patrickhlauke
Copy link
Member Author

As this goes outside of my comfort zone, I'd appreciate a good hard look from @smaug---- and @NavidZ to make sure this makes sense?

@smaug----
Copy link
Contributor

That change seems to capture the requirement.
The same thing could be possibly expressed with 'connected'.
https://dom.spec.whatwg.org/#connected

@patrickhlauke
Copy link
Member Author

patrickhlauke commented Apr 3, 2018

what would be clearer do you think? something like

If the <code>Element</code> on which this method is invoked is not <code>connected</code> [[!DOM4]] - i.e. if the <code>ownerDocument</code> of the <code>Element</code> is not a shadow-including ancestor [[!DOM4]] of the element - throw an exception with the name <code>InvalidStateError</code>
@smaug----
Copy link
Contributor

Using 'connected' might be easier to read, though if one is not familiar with the term, one needs to look at the DOM spec. Anyhow, 'connected' should be fine.

@patrickhlauke patrickhlauke changed the title Introduce concept of shadow-including ancestor for pointer capture Apr 3, 2018
@patrickhlauke
Copy link
Member Author

thanks @smaug----

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants