Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a note on null fromElement and toElement. #234

Merged
merged 2 commits into from
Mar 23, 2018

Conversation

mustaqahmed
Copy link
Member

Closes #167.

index.html Outdated
<p>For all pointer events in the table above, <code>composed</code> ([[!WHATWG-DOM]]) attribute SHOULD be <code>true</code> and <a href="https://www.w3.org/TR/uievents/#widl-UIEvent-detail"><code>detail</code></a> [[!DOM-LEVEL-3-EVENTS]] attribute SHOULD be 0.</p>
<p>Similar to the <a href="https://www.w3.org/TR/uievents/#interface-mouseevent">MouseEvents</a> [[!DOM-LEVEL-3-EVENTS]] the <code>relatedTarget</code> should be initialized to the element whose bounds the pointer just left (in the case of a <code>pointerover</code> or <code>pointerenter</code> event) or the element whose bounds the pointer is entering (in the case of a <code>pointerout</code> or <code>pointerleave</code>). For other pointer events, this value will default to null. Note that when an element receives the pointer capture all the following events for that pointer are considered to be inside the boundary of the capturing element.</p>

<div class="note">Many user agents expose non-standard attributes <code>fromElement</code> and <code>toElement</code> in MouseEvents to support legacy content. In those user agents, the values of those (inherited) attributes in PointerEvents must be <code>null</code> to encourage the use of the standardized alternates (i.e. <code>target</code> and <code>relatedTarget</code>).</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to fold this along with the detail attribute in the earlier paragraph? I guess they all fall into the same bucket.
Also beside this paragraph there is no other change in other lines except indentation and extra spaces. Right? if you remove those that might be easier to catch the actual changes and review them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The problem is that (unlike detail and composed) these two attributes are not spec-ed or even described clearly anywhere. I think a normative text won't make sense. I moved the Note up, right after the para on other attributes.
    Does it look reasonable now?

  • Yikes, I only looked at a local diff tool so didn't realize that whitespace changes are not visible here. Sorry.

@NavidZ
Copy link
Member

NavidZ commented Mar 23, 2018

Thanks. looks good to me now.

@mustaqahmed mustaqahmed merged commit 559cf0c into w3c:gh-pages Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants