-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing feedback from the AC Vote #371
Conversation
I can't seem to add Mark as a reviewer, so I'm pinging here: @mnot |
Thank you, Wendy. This looks great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change based on my feedback looks good, so I'll hit 'Approve'. That said, the rest of the diff is quite hard to read; I suspect there are spurious whitespace / formatting changes mixed in with the substantive ones. That's unfortunate, and makes the diff as a whole hard to review.
index.html
Outdated
@@ -92,6 +92,9 @@ <h3> | |||
<h2> | |||
Introduction | |||
</h2> | |||
<p class="note"> | |||
This document was formerly known as the Code of Ethics and Professional Conduct, and references to that name may still appear in other W3C documents. If there is a reference to the Code of Ethics and Professional Coduct, or CEPC, it is referring to this document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Thanks, this is an improvement. |
Thank you! I need to set up the preview link for this repo, I got a little carried away with formatting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1 to all the whitespace changes. I would welcome intentional wholesale reformatting of the source code for consistency and/or introducing semantic line breaking; but not in this PR because it's confusing. :)
Wrt the substantive changes, the Member Agreement refers to the CEPC by name (see https://www.w3.org/2023/01/Member-Agreement ) and that's a legal document, so I'm not sure it's enough to just add a historical note?
My suggestion would be to put a sentence either in the Intro or in the Status section that unambiguously says "This is the W3C Code of Ethics and Professional Conduct (CEPC)". It can also say other things, like: "This is the W3C Code of Ethics and Professional Conduct (CEPC); and has been retitled Code of Conduct for [reasons]." Or whatever.
@chrisn Thank you for your feedback on the AC review, I have added some editorial changes in line with the feedback, would it be possible for you to review this so I can merge this PR? |
@fantasai I have addressed your suggestion in the latest commit. I cannot do anything about whitespace at this time but I will address it in a future PR dedicated to fixing all of the inconsistencies. |
A reviewer submitted the following comments to the Team, requesting that the Team forward them. I think they have been adequately addressed in this PR, but documenting them here for the record:
|
@swickr Thank you for sharing the feedback, I agree that I believe the comments are addressed, but just for the benefit of the submitter, I'll provide some direct pointers that are applicable to their concerns:
We don't have a specific recommendation regarding "time" as it's a challenge to quantify considering our work mode (too much time in calls? Spent reading GitHub issues?), if the reviewer has a recommendation, or would like to explore the topic further, we recommend opening an issue in this repo so we can explore it for a future revision. I think it's a worthy topic to explore, I wouldn't want to attempt to force something in without discussion.
See section 7, and point 4 of section 14.
See section 14. Re: Readability, I don't see the proposed revised text mentioned, so I'm not sure what the suggested changes are. |
I'm only asking to update this PR so that it doesn't include unnecessary whitespace changes (so that it's easy to review what's actually changed). Not sure why that can't/shouldn't be done? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates LGTM too. Also ok with reverting the whitespace changes (presumably copy-pasting those lines from the old into additional commits on the new).
Pulling together changes to reflect feedback from the AC Vote that is currently in progress.
Preview | Diff